feat: sync mcs work when cluster joined or unjoin #4360
Conversation
karmada-bot
added
the
kind/feature
karmada-bot
added
the
size/L
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4360 +/- ##
==========================================
+ Coverage 51.78% 51.88% +0.09%
==========================================
Files 243 243
Lines 24112 24114 +2
==========================================
+ Hits 12487 12511 +24
+ Misses 10944 10921 -23
- Partials 681 682 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Rains6
force-pushed
the
dev-mcs-zhc
branch
2 times, most recently
from
2bdfca4 to
b21bc54
Compare
Rains6
changed the title
karmada-bot
added
size/M
|
I've made some changes: jwcesign@54312e0 Please review and incorporate any appropriate adjustments. |
…sponding cluster execution namespace Signed-off-by: HongCen <zhouhongcen1@huawei.com>
|
lgtm |
| @@ -460,6 +474,47 @@ func (c *MCSController) SetupWithManager(mgr controllerruntime.Manager) error { | |||
| return controllerruntime.NewControllerManagedBy(mgr). | |||
| For(&networkingv1alpha1.MultiClusterService{}, builder.WithPredicates(mcsPredicateFunc)). | |||
| Watches(&corev1.Service{}, handler.EnqueueRequestsFromMapFunc(svcMapFunc), builder.WithPredicates(svcPredicateFunc)). | |||
| Watches(&clusterv1alpha1.Cluster{}, handler.EnqueueRequestsFromMapFunc(c.clusterMapFunc())). | |||
There was a problem hiding this comment.
@jwcesign
Do we need to add an event filter?
Note that each cluster change would lead to list of all MultiClusterService in clusterMapFunc().
There was a problem hiding this comment.
We can only accept changes to the cluster status condition.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
What type of PR is this?
/kind feature
What this PR does / why we need it:
Referring to #4287
Which issue(s) this PR fixes:
Part of #4292
Special notes for your reviewer:
none
Does this PR introduce a user-facing change?: