-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg: test federatedresourcequota
webhook
#5287
pkg: test federatedresourcequota
webhook
#5287
Conversation
In this commit, we add unit tests for the `FederatedResourceQuota` validation logic and its related components. The tests ensure that the validation logic correctly handles various scenarios, including: - Validating `FederatedResourceQuota` specifications with appropriate resource assignments. - Detecting cases where overall resource limits are less than the assigned resources. - Handling scenarios where resource names in assignments do not exist in the overall resources. - Validating `FederatedResourceQuotaStatus` to ensure standard resource types and correct cluster names. - Handling invalid resource lists in both `Overall` and `AggregatedStatus`. Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5287 +/- ##
==========================================
+ Coverage 28.23% 28.35% +0.11%
==========================================
Files 632 632
Lines 43762 43762
==========================================
+ Hits 12357 12409 +52
+ Misses 30504 30452 -52
Partials 901 901
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks @mohamedawnallah |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mohamedawnallah thanks a lot.
Your test code is clearly written and your test cases are well designed to ensure test coverage. Good Job!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
In this commit, we add unit tests for the
FederatedResourceQuota
validation logic and its related components. The tests ensure that the validation logic correctly handles various scenarios, including:FederatedResourceQuota
specifications with appropriate resource assignments.FederatedResourceQuotaStatus
to ensure standard resource types and correct cluster names.Overall
andAggregatedStatus
.Test Coverage
The test case coverage has been increased from 30.2% to 100% 🎉. This can be verified in the
pkg/webhook/federatedresourcequota
directory by running the following commands:go test -coverprofile=coverage.out go tool cover -html=coverage.out -o coverage.html
What type of PR is this?
/kind failing-test
Which issue(s) this PR fixes:
Part of #5491
Special notes for your reviewer:
Does this PR introduce a user-facing change?: