Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg: test federatedresourcequota webhook #5287

Conversation

mohamedawnallah
Copy link
Contributor

@mohamedawnallah mohamedawnallah commented Aug 1, 2024

Description

In this commit, we add unit tests for the FederatedResourceQuota validation logic and its related components. The tests ensure that the validation logic correctly handles various scenarios, including:

  • Validating FederatedResourceQuota specifications with appropriate resource assignments.
  • Detecting cases where overall resource limits are less than the assigned resources.
  • Handling scenarios where resource names in assignments do not exist in the overall resources.
  • Validating FederatedResourceQuotaStatus to ensure standard resource types and correct cluster names.
  • Handling invalid resource lists in both Overall and AggregatedStatus.

Test Coverage

The test case coverage has been increased from 30.2% to 100% 🎉. This can be verified in the pkg/webhook/federatedresourcequota directory by running the following commands:

go test -coverprofile=coverage.out
go tool cover -html=coverage.out -o coverage.html

What type of PR is this?

/kind failing-test

Which issue(s) this PR fixes:

Part of #5491

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

In this commit, we add unit tests for the `FederatedResourceQuota`
validation logic and its related components. The tests ensure that
the validation logic correctly handles various scenarios, including:

- Validating `FederatedResourceQuota` specifications with appropriate resource assignments.
- Detecting cases where overall resource limits are less than the assigned resources.
- Handling scenarios where resource names in assignments do not exist in the overall resources.
- Validating `FederatedResourceQuotaStatus` to ensure standard resource types and correct cluster names.
- Handling invalid resource lists in both `Overall` and `AggregatedStatus`.

Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
@karmada-bot karmada-bot added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Aug 1, 2024
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 1, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.35%. Comparing base (145a67e) to head (7373ab3).
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5287      +/-   ##
==========================================
+ Coverage   28.23%   28.35%   +0.11%     
==========================================
  Files         632      632              
  Lines       43762    43762              
==========================================
+ Hits        12357    12409      +52     
+ Misses      30504    30452      -52     
  Partials      901      901              
Flag Coverage Δ
unittests 28.35% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@XiShanYongYe-Chang
Copy link
Member

Thanks @mohamedawnallah
/assign

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mohamedawnallah thanks a lot.

Your test code is clearly written and your test cases are well designed to ensure test coverage. Good Job!

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2024
@karmada-bot karmada-bot merged commit 04a4d84 into karmada-io:master Aug 2, 2024
12 checks passed
@RainbowMango RainbowMango added this to the v1.11 milestone Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants