Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LFX-Mentorship-Term3-2024-Tracking-Issue] Enhance the test coverage for the Karmada search, operator, and webhook components #5491

Open
mohamedawnallah opened this issue Sep 7, 2024 · 15 comments
Open

[LFX-Mentorship-Term3-2024-Tracking-Issue] Enhance the test coverage for the Karmada search, operator, and webhook components #5491

mohamedawnallah opened this issue Sep 7, 2024 · 15 comments
Assignees
@mohamedawnallah
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@mohamedawnallah
Copy link
Contributor

mohamedawnallah commented Sep 7, 2024 •
edited
Loading

Upstream Issue

#5236

Legend

  • ⬜: No PR issued yet
  • ⏳: In Review
  • ✅: Merged

Milestone 1 - Karmada Webhooks Test Coverage

Status Period Directory Old Coverage New Coverage PR Code Quality Docs Quality Bug Discovery
✅
 Sep 7-13 pkg/webhook/propagationpolicy
0%
N/A
N/A
N/A
✅
 Sep 7-13 pkg/webhook/clusterpropagationpolicy
0%
N/A
N/A
N/A
✅
 Sep 7-13 pkg/webhook/overridepolicy
0%
N/A
N/A
N/A
✅
 Sep 7–13 pkg/webhook/clusteroverridepolicy
0%
N/A
N/A
N/A
✅
 Sep 7-13 pkg/webhook/resourcebinding
0%
N/A
N/A
N/A
N/A
✅
 Sep 7-13 pkg/webhook/clusterresourcebinding
0%
N/A
N/A
N/A
N/A
✅
 Sep 7-13 pkg/webhook/resourcedeletionprotection
0%
N/A
N/A
N/A
N/A
✅
 Sep 7-13 pkg/webhook/federatedhpa
0%
N/A
N/A
N/A
N/A
✅
 Sep 7-13 pkg/webhook/multiclusteringress
0%
N/A
N/A
N/A
N/A
✅
 Sep 7-13 pkg/webhook/work
0%
N/A
N/A
N/A
N/A
✅
 Sep 7-13 pkg/webhook/interpreter
0%
N/A
N/A
N/A
N/A
✅
 Sep 7-13 pkg/webhook/federatedresourcequota
30.2%
N/A
N/A
N/A
✅
 Sep 7-13 pkg/webhook/multiclusterservice
47.92%
N/A
N/A
N/A
✅
 Sep 7–13 pkg/webhook/resourceinterpretercustomization
61.36%
N/A
N/A
N/A
N/A

Milestone 2 - Karmada Operator Test Coverage (1/4)

Status Period Directory Old Coverage New Coverage PR Code Quality Docs Quality Bug Discovery
✅
 Sep 14–20 Any backlog from previous milestone
N/A
N/A
N/A
N/A
N/A
N/A
✅
 Sep 14–20 operator/pkg/certs
0%
N/A
N/A
✅
 Sep 14-20 operator/pkg/controller/karmada
0%
N/A
N/A
N/A
N/A
✅
 Sep 14-20 operator/pkg/controlplane
0%
N/A
N/A
N/A
N/A
✅
 Sep 14-20 operator/pkg/controlplane/apiserver
0%
N/A
N/A
N/A
N/A
✅
 Sep 14-20 operator/pkg/controlplane/etcd
0%
N/A
N/A
N/A
N/A
✅
 Sep 14-20 operator/pkg/controlplane/metricsadapter
0%
N/A
N/A
N/A
N/A
✅
 Sep 14-20 operator/pkg/controlplane/search
0%
N/A
N/A
N/A
N/A
✅
 Sep 14-20 operator/pkg/controlplane/webhook
0%
N/A
N/A
N/A
N/A
✅
 Sep 14-20 operator/pkg/karmadaresource/apiservice
0%
N/A
N/A
N/A
✅
 Sep 14-20 operator/pkg/karmadaresource/rbac
0%
N/A
N/A
N/A
N/A
✅
 Sep 14-20 operator/pkg/karmadaresource/webhookconfiguration
0%
N/A
N/A
N/A
N/A
✅
 Sep 14-20 operator/pkg/scheme
0%
N/A
N/A
N/A
N/A

Milestone 3 - Karmada Operator Test Coverage (2/4)

Status Period Directory Old Coverage New Coverage PR Code Quality Docs Quality Bug Discovery
✅
 Sep 21–27 Any backlog from previous milestone
N/A
N/A
N/A
N/A
N/A
N/A
⏳
 Sep 21–27 operator/pkg
0%
N/A
N/A
N/A
⏳
 Sep 21–27 operator/pkg/tasks/init
0%
N/A
N/A
N/A
N/A
✅
 Sep 21–27 operator/pkg/tasks/deinit
0%
N/A
N/A
N/A
N/A

Milestone 4 - Karmada Operator Test Coverage (3/4)

Status Period Directory Old Coverage New Coverage PR Code Quality Docs Quality Bug Discovery
✅
 Sep 28 - Oct 4 Any backlog from previous milestone
N/A
N/A
N/A
N/A
N/A
N/A
✅
 Sep 28 - Oct 4 operator/pkg/workflow
0%
N/A
N/A
N/A
N/A
✅
 Sep 28 - Oct 4 operator/pkg/util/patcher
0%
N/A
N/A
N/A
N/A
⏳
 Sep 28 - Oct 4 operator/pkg/util/apiclient
0%
N/A
N/A
N/A
N/A

Milestone 5 - Karmada Operator Test Coverage (4/4)

Status Period Directory Old Coverage New Coverage PR Code Quality Docs Quality Bug Discovery
✅
 Oct 5-11 Any backlog from previous milestone
N/A
N/A
N/A
N/A
N/A
N/A
✅
 Oct 5-11 operator/pkg/util
0%
N/A
N/A
N/A
N/A

Milestone 6 - Test Coverage Review and Refinement

Status Period Directory Old Coverage New Coverage PR Code Quality Docs Quality Bug Discovery
✅
 Oct 12-18 Any backlog from previous milestones
N/A
N/A
N/A
N/A
N/A
N/A

Milestone 7 - Karmada Search Coverage

Status Period Directory Old Coverage New Coverage PR Code Quality Docs Quality Bug Discovery
⏳
 Oct 26 - Nov 1 pkg/search/backendstore
0%
N/A
N/A
N/A
N/A
✅
 Oct 26 - Nov 1 pkg/search
0%
N/A
N/A
N/A
N/A

Milestone 8- Remaining Code Coverage (1/3)

Status Period Directory Old Coverage New Coverage PR Code Quality Docs Quality Bug Discovery
✅
 Oct 26 - Nov 1 Any backlog from previous milestone
N/A
N/A
N/A
N/A
N/A
N/A
✅
 Oct 26 - Nov 1 pkg/aggregatedapiserver
0%
N/A
N/A
N/A
N/A
⏳
 Oct 26 - Nov 1 pkg/clusterdiscovery/clusterapi
0%
N/A
N/A
N/A
N/A
✅
 Oct 26 - Nov 1 pkg/karmadactl/addons/descheduler
0%
N/A
N/A
N/A
N/A
⏳
 Oct 26 - Nov 1 pkg/karmadactl/addons/estimator
0%
N/A
N/A
N/A
N/A
⏳
 Oct 26 - Nov 1 pkg/karmadactl/addons/init
0%
N/A
N/A
N/A
N/A
⏳
 Oct 26 - Nov 1 pkg/karmadactl/addons/install
0%
N/A
N/A
N/A
N/A
✅
 Oct 26 - Nov 1 pkg/karmadactl/addons/metricsadapter
0%
N/A
N/A
N/A
N/A
✅
 Oct 26 - Nov 1 pkg/karmadactl/addons/search
0%
N/A
N/A
N/A
N/A
⏳
 Oct 26 - Nov 1 pkg/karmadactl/apply
0%
N/A
N/A
N/A
N/A
✅
 Oct 26 - Nov 1 pkg/karmadactl/cmdinit/bootstraptoken/agent/tlsbootstrap.go
0%
N/A
N/A
N/A
N/A
✅
 Oct 26 - Nov 1 pkg/karmadactl/cmdinit/bootstraptoken/clusterinfo
0%
N/A
N/A
N/A
N/A
✅
 Oct 26 - Nov 1 pkg/karmadactl/cmdinit/karmada
0%
N/A
N/A
N/A
N/A

Milestone 9 - Remaining Code Coverage (2/3)

Status Period Directory Old Coverage New Coverage PR Code Quality Docs Quality Bug Discovery
✅
 Nov 2-8 Any backlog from previous milestone
N/A
N/A
N/A
N/A
N/A
N/A
✅
 Nov 2-8 pkg/karmadactl/cordon
0%
N/A
N/A
N/A
N/A
⏳
 Nov 2-8 pkg/karmadactl/deinit
0%
N/A
N/A
N/A
N/A
✅
 Nov 2-8 pkg/karmadactl/describe
0%
N/A
N/A
N/A
N/A
✅
 Nov 2-8 pkg/karmadactl/exec
0%
N/A
N/A
N/A
N/A
⬜
 Nov 2-8 pkg/karmadactl/get
0%
N/A
N/A
N/A
N/A
N/A
✅
 Nov 2-8 pkg/karmadactl/logs
0%
N/A
N/A
N/A
N/A
✅
 Nov 2-8 pkg/karmadactl/promote
0%
N/A
N/A
N/A
N/A
⬜
 Nov 2-8 pkg/karmadactl/register
0%
N/A
N/A
N/A
N/A
N/A
⬜
 Nov 2-8 pkg/karmadactl/top
0%
N/A
N/A
N/A
N/A
N/A
✅
 Nov 2-8 pkg/karmadactl/join
0%
N/A
N/A
N/A
N/A
✅
 Nov 2-8 pkg/karmadactl/unjoin
0%
N/A
N/A
N/A
N/A
⏳
 Nov 2-8 pkg/karmadactl/util/apiclient
0%
N/A
N/A
N/A
N/A
⬜
 Nov 2-8 pkg/metricsadapter
0%
N/A
N/A
N/A
N/A
N/A

Milestone 10 - Remaining Code Coverage (3/3)

Status Period Directory Old Coverage New Coverage PR Code Quality Docs Quality Bug Discovery
⬜
 Nov 9-15 Any backlog from previous milestone
N/A
N/A
N/A
N/A
N/A
N/A
⬜
 Nov 9-15 pkg/karmadactl/options
5.77%
N/A
N/A
N/A
N/A
N/A
⬜
 Nov 9-15 pkg/registry/cluster/storage
7.39%
N/A
N/A
N/A
N/A
N/A
⬜
 Nov 9-15 pkg/karmadactl/addons
10.55%
N/A
N/A
N/A
N/A
N/A
⬜
 Nov 9-15 pkg/karmadactl/util
20.02%
N/A
N/A
N/A
N/A
N/A
⬜
 Nov 9-15 pkg/sharedcli
22.78%
N/A
N/A
N/A
N/A
N/A
⬜
 Nov 9-15 pkg/registry/search/storage
26.34%
N/A
N/A
N/A
N/A
N/A
⬜
 Nov 9-15 pkg/karmadactl/interpret
29.06%
N/A
N/A
N/A
N/A
N/A
⬜
 Nov 9-15 pkg/metrics
34.74%
N/A
N/A
N/A
N/A
N/A
⬜
 Nov 9-15 pkg/karmadactl/util/genericresource
36.27%
N/A
N/A
N/A
N/A
N/A
⬜
 Nov 9-15 pkg/karmadactl/taint
43.33%
N/A
N/A
N/A
N/A
N/A

Milestone 11 - Final Code Review and Coverage Validation

Status Period Directory Old Coverage New Coverage PR Code Quality Docs Quality Bug Discovery
⬜
 Nov 16-20 Any backlog from previous milestone
N/A
N/A
N/A
N/A
N/A
N/A

Milestone 12 - Detailed Report on Improved Test Coverage

Status Period Directory Old Coverage New Coverage PR Code Quality Docs Quality Bug Discovery
⬜
 Nov 21-25 A Detailed Blog Post Reporting on Improved Test Coverage Across the Project
N/A
N/A
N/A
N/A
N/A
N/A
@mohamedawnallah mohamedawnallah added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 7, 2024
@mohamedawnallah mohamedawnallah mentioned this issue Sep 7, 2024
Merged
@mohamedawnallah
Copy link
Contributor Author

mohamedawnallah commented Sep 7, 2024 •
edited
Loading

Hi @anujagrawal699,

Do any of these overlap with your project (#5470)? Please let me know if I overlooked something so we can avoid any potential duplication of effort.

Thanks!

@mohamedawnallah mohamedawnallah changed the title [lfx-mentorship-2024-Tracking-Issue] Enhance the test coverage for the Karmada search, operator, and webhook components [lfx-mentorship-Fall-2024-Tracking-Issue] Enhance the test coverage for the Karmada search, operator, and webhook components Sep 7, 2024
@mohamedawnallah mohamedawnallah changed the title [lfx-mentorship-Fall-2024-Tracking-Issue] Enhance the test coverage for the Karmada search, operator, and webhook components [lfx-mentorship-Term3-2024-Tracking-Issue] Enhance the test coverage for the Karmada search, operator, and webhook components Sep 7, 2024
@mohamedawnallah mohamedawnallah changed the title [lfx-mentorship-Term3-2024-Tracking-Issue] Enhance the test coverage for the Karmada search, operator, and webhook components [LFX-Mentorship-Term3-2024-Tracking-Issue] Enhance the test coverage for the Karmada search, operator, and webhook components Sep 7, 2024
@anujagrawal699
Copy link
Contributor

Hi @anujagrawal699,

Do any of these overlap with your project (#5470)? Please let me know if I overlooked something so we can avoid any potential duplication of effort.

Thanks!

Hey @mohamedawnallah . Everything looks good and structured. Good Job!

This was referenced Sep 9, 2024
Merged
Merged
Merged
Merged
Merged
Merged
@XiShanYongYe-Chang
Copy link
Member

Good job! It's a detailed plan. Let's follow it.

@XiShanYongYe-Chang XiShanYongYe-Chang mentioned this issue Sep 9, 2024
Closed
@XiShanYongYe-Chang
Copy link
Member

/assign @mohamedawnallah

This was referenced Sep 9, 2024
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
@mohamedawnallah mohamedawnallah mentioned this issue Sep 16, 2024
Merged
@mohamedawnallah
Copy link
Contributor Author

Update: The ResourceInterpreterCustomization validation admission webhook was not included in Milestone 1 for the webhooks. A PR (#5562) was submitted during Milestone 2 to address this.

This was referenced Sep 18, 2024
Merged
Merged
This was referenced Oct 30, 2024
Merged
Merged
Merged
Open
Open
Merged
Open
Merged
Open
Merged
This was referenced Nov 8, 2024
Merged
Merged
Open
@mohamedawnallah mohamedawnallah mentioned this issue Nov 16, 2024
Open
@mohamedawnallah
Copy link
Contributor Author

mohamedawnallah commented Nov 16, 2024 •
edited
Loading

Milestone 7 Update:
I came across pkg/search/proxy/framework/runtime/framework.go related to framework code and I don't see any critical code that requires immediate testing. We can prioritize this later, but if you have a different opinion, please let me know so we can adjust the priorities accordingly.

This was referenced Nov 17, 2024
Merged
Open
Merged
@mohamedawnallah
Copy link
Contributor Author

Milestone 10 Updates:

I came across the following components:

  • pkg/apis/work: This is related to the API specification. I don't see any critical code here that would require immediate testing.
  • pkg/karmadactl/util/testing: This pertains to fake testing, and I don't believe there's any critical code that requires urgent testing.
  • pkg/version: This is related to version code, particularly the command configurations. Testing these configurations doesn’t seem to be of immediate importance.
  • pkg/karmadactl/karmadactl.go: This involves karmadactl command configurations, and similar to the others, I think testing these configurations wouldn't be particularly useful.

In these cases, I don't see any critical code that requires immediate testing. We can prioritize this later, but if you have a different perspective, please let me know so we can adjust the priorities accordingly.

This was referenced Nov 24, 2024
Merged
Merged
Merged
Merged
Merged
@mohamedawnallah
Copy link
Contributor Author

Hi @XiShanYongYe-Chang,

I’m fully committed to completing the remaining unit tests as I planned to enhance code coverage and ensure Karmada achieves an even stronger and more reliable state post-LFX mentorship. Thank you for your invaluable guidance throughout this journey! 🙏

@XiShanYongYe-Chang
Copy link
Member

Thank you for your contribution @mohamedawnallah :)

In view of your outstanding performance in the Karmada community, I'd like to invite you to join Karmada as a member. Would you like to do so?

@mohamedawnallah
Copy link
Contributor Author

mohamedawnallah commented Nov 28, 2024 •
edited
Loading

In view of your outstanding performance in the Karmada community, I'd like to invite you to join Karmada as a member. Would you like to do so?

@XiShanYongYe-Chang Yes, it would be an absolute honor to be part of this incredible community. From the moment I made my first contribution, Karmada welcomed me with open arms, and I’ve been excited ever since to contribute to the growth of open-source cloud computing, a space where Karmada truly stands out. 🙏

I will submit a Karmada Membership Issue Request by the end of the day.

@zhzhuang-zju
Copy link
Contributor

I will submit a Karmada Membership Issue Request by the end of the day.

@mohamedawnallah Thank you for your contribution, I am very willing to vote on your Membership Issue.

This was referenced Nov 28, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mohamedawnallah mohamedawnallah

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
Karmada Overall Backlog
Status: No status
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mohamedawnallah @XiShanYongYe-Chang @zhzhuang-zju @anujagrawal699