pkg/webhook: unit test Multi-Cluster Service #5517
Conversation
karmada-bot
added
the
size/XL
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5517 +/- ##
==========================================
+ Coverage 33.71% 33.81% +0.10%
==========================================
Files 643 643
Lines 44500 44500
==========================================
+ Hits 15001 15048 +47
+ Misses 28357 28308 -49
- Partials 1142 1144 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
|
/retest |
|
Hi @mohamedawnallah, can you help rebase the master branch and push it again? |
In this commit, we introduce unit tests for both the `ValidationAdmission`
and `MutatingAdmission` webooks specifically for the `MultiClusterService` resource.
- Validation webhook tests:
- Tests the behavior when decoding the request object fails, verifying
that admission is denied with an appropriate error message.
- Validates that the webhook denies admission when encountering invalid
values in the `MultiClusterService` spec, ensuring error messaging.
- Confirms that valid `MultiClusterService` objects are admitted without errors.
- Mutation webhook tests:
- Handles decode errors and denies admission when decoding fails.
- Provides full coverage of `MultiClusterService` object mutation,
including setting default namespaces and validating no unnecessary patches.
Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
mohamedawnallah
force-pushed
the
unitTestMultiClusterService
branch
from
bb22f43 to
d5c9a9d
Compare
|
/lgtm |
Description
In this commit, we introduce unit tests for both the
ValidationAdmissionandMutatingAdmissionwebooks specifically for theMultiClusterServiceresource.The tests include:
Validation webhook tests:
MultiClusterServicespec, ensuring error messaging.MultiClusterServiceobjects are admitted without errors.Mutation webhook tests:
MultiClusterServiceobject mutation, including setting default namespaces and validating no unnecessary patches.What type of PR is this?
Which issue(s) this PR fixes:
Part of #5491.
Does this PR introduce a user-facing change?: