Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator/pkg: unit test init and deinit #5613

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mohamedawnallah
Copy link
Contributor

@mohamedawnallah mohamedawnallah commented Sep 26, 2024

Description

In this commit, we unit test the init and deinit workflows in the operator pkg.

What type of PR is this?

Which issue(s) this PR fixes:
Part of #5491.

Dependency:
This PR depends on #5616, #5617, and #5630.

Does this PR introduce a user-facing change?:

NONE

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lonelycz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 26, 2024
@mohamedawnallah mohamedawnallah force-pushed the unitTestKarmadaInitAndDeinitOperatorPkg branch from ac415bc to 169c520 Compare September 26, 2024 21:03
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 58.18182% with 23 lines in your changes missing coverage. Please review.

Project coverage is 36.36%. Comparing base (4c8bcd4) to head (1760599).
Report is 62 commits behind head on master.

Files with missing lines Patch % Lines
operator/pkg/test_helper.go 46.66% 10 Missing and 6 partials ⚠️
operator/pkg/controller/karmada/planner.go 0.00% 2 Missing ⚠️
operator/pkg/init.go 85.71% 1 Missing and 1 partial ⚠️
operator/pkg/util/kubeconfig.go 0.00% 2 Missing ⚠️
operator/pkg/deinit.go 85.71% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5613      +/-   ##
==========================================
+ Coverage   34.14%   36.36%   +2.21%     
==========================================
  Files         643      646       +3     
  Lines       44524    44891     +367     
==========================================
+ Hits        15203    16323    +1120     
+ Misses      28165    27302     -863     
- Partials     1156     1266     +110     
Flag Coverage Δ
unittests 36.36% <58.18%> (+2.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mohamedawnallah mohamedawnallah force-pushed the unitTestKarmadaInitAndDeinitOperatorPkg branch from 169c520 to 7f481a7 Compare September 27, 2024 09:58
@karmada-bot karmada-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 27, 2024
@mohamedawnallah mohamedawnallah force-pushed the unitTestKarmadaInitAndDeinitOperatorPkg branch 2 times, most recently from 145231c to 1760599 Compare September 27, 2024 12:10
@mohamedawnallah mohamedawnallah force-pushed the unitTestKarmadaInitAndDeinitOperatorPkg branch 2 times, most recently from c238375 to 03f39de Compare September 27, 2024 12:42
@mohamedawnallah mohamedawnallah force-pushed the unitTestKarmadaInitAndDeinitOperatorPkg branch from 03f39de to 41ccb6f Compare September 27, 2024 13:03
@mohamedawnallah mohamedawnallah changed the title operator/pkg: unit test init and deinit [WIP] operator/pkg: unit test init and deinit Sep 27, 2024
@mohamedawnallah mohamedawnallah force-pushed the unitTestKarmadaInitAndDeinitOperatorPkg branch from 41ccb6f to 32792cf Compare October 1, 2024 04:51
In this commit, we unit test the init and deinit workflows
in the operator pkg.

Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
@mohamedawnallah mohamedawnallah force-pushed the unitTestKarmadaInitAndDeinitOperatorPkg branch from c87ad2b to b36ebcb Compare October 18, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants