operator+pkg: depend on clientset.Interface
instead of *clientset.Clientset
#5616
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this commit, we apply the Dependency Inversion Principle by depending on an interface instead of a concrete type. This improves flexibility and testability.
Motivation and Context
While testing the Karmada Init and DeInit in the operator package (#5613), I found it difficult to mock
*clientset.Clientset
, complicating unit tests. By refactoring to depend on an interface, we improve flexibility and testability, allowing for the integration of a fake clientset since it implements that interface.What type of PR is this?
/kind cleanup
Does this PR introduce a user-facing change?: