-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/karmadactl/addons: unit test install addons #5754
pkg/karmadactl/addons: unit test install addons #5754
Conversation
77ad2ce
to
f7feac0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5754 +/- ##
==========================================
+ Coverage 41.63% 41.87% +0.24%
==========================================
Files 655 655
Lines 55753 55756 +3
==========================================
+ Hits 23211 23348 +137
+ Misses 31036 30896 -140
- Partials 1506 1512 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
In this commit, we unit test install addons to make sure the following addons `karmada-descheduler`, `karmada-metrics-adapter`, `karmada-scheduler-estimator`, and `karmada-search` are already configured. Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
f7feac0
to
4ab6bff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
In this commit, we unit test install addons to make sure the following addons
karmada-descheduler
,karmada-metrics-adapter
,karmada-scheduler-estimator
, andkarmada-search
are already configured.What type of PR is this?
Which issue(s) this PR fixes:
Part of #5491.
Does this PR introduce a user-facing change?: