-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator/pkg/tasks/init: unit test cert #5625
operator/pkg/tasks/init: unit test cert #5625
Conversation
77a36e9
to
3fd9775
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5625 +/- ##
==========================================
+ Coverage 39.75% 40.19% +0.44%
==========================================
Files 650 650
Lines 55147 55147
==========================================
+ Hits 21924 22168 +244
+ Misses 31815 31547 -268
- Partials 1408 1432 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
0753add
to
6a76624
Compare
6a76624
to
561f5cd
Compare
561f5cd
to
62b6f6b
Compare
Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
62b6f6b
to
33b75f7
Compare
cc @XiShanYongYe-Chang All test cases passed after PR #5561 was merged and rebasing on master branch :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
In this commit, we introduce unit tests for the cert operator package, covering tasks such as creating new certificates, running existing certificates, and skipping certificates.
What type of PR is this?
Which issue(s) this PR fixes:
Part of #5491.
Depends on #5561 and #5630.
Does this PR introduce a user-facing change?: