Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator/pkg/tasks/init: unit test karmada resource #5701

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mohamedawnallah
Copy link
Contributor

Description

In this commit, we unit test karmada resource init task on running karmada resources, system namespaces, crds, webhook configurations, and api service.

What type of PR is this?

Which issue(s) this PR fixes:
Part of #5491.

Does this PR introduce a user-facing change?:

NONE

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 16.66667% with 15 lines in your changes missing coverage. Please review.

Project coverage is 38.72%. Comparing base (0d55ead) to head (6630227).

Files with missing lines Patch % Lines
operator/pkg/tasks/init/karmadaresource.go 18.18% 9 Missing ⚠️
operator/pkg/util/util.go 0.00% 3 Missing ⚠️
operator/pkg/util/apiclient/idempotency.go 0.00% 2 Missing ⚠️
operator/pkg/util/apiclient/wait.go 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5701      +/-   ##
==========================================
- Coverage   39.09%   38.72%   -0.38%     
==========================================
  Files         650      650              
  Lines       45209    55132    +9923     
==========================================
+ Hits        17676    21350    +3674     
- Misses      26180    32413    +6233     
- Partials     1353     1369      +16     
Flag Coverage Δ
unittests 38.72% <16.66%> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mohamedawnallah mohamedawnallah force-pushed the unitTestKarmadaResourceInitTask branch from 09c5c2f to f77d62c Compare October 17, 2024 14:50
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lonelycz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 17, 2024
@mohamedawnallah mohamedawnallah force-pushed the unitTestKarmadaResourceInitTask branch from f77d62c to 3e6f5f3 Compare October 17, 2024 16:27
In this commit, we unit test karmada resource init task on
running karmada resources, system namespaces, crds,
webhook configurations, and api service.

Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
@mohamedawnallah mohamedawnallah force-pushed the unitTestKarmadaResourceInitTask branch from 3e6f5f3 to 6630227 Compare October 17, 2024 16:39
@mohamedawnallah
Copy link
Contributor Author

cc @XiShanYongYe-Chang All unit test cases & linting issues passed after rebasing on the master branch :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants