Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/webhook: unit test propagation policy #5492

Merged
merged 1 commit into from
Sep 10, 2024
Merged

pkg/webhook: unit test propagation policy #5492

merged 1 commit into from
Sep 10, 2024

Conversation

mohamedawnallah
Copy link
Contributor

@mohamedawnallah mohamedawnallah commented Sep 7, 2024 •
edited
Loading

Description

In this commit, we introduce unit tests for both the ValidatingAdmission and MutatingAdmission webhooks for the PropagationPolicy resource.

The tests include:

  • Validation webhook tests:

    • Tests how the webhook responds when decoding the request object fails.
    • Ensures that updates to the SchedulerName field are denied, as it should remain immutable.
    • Validates that changes to the PropagationPolicyPermanentIDLabel label and its absence in creation requests are correctly handled.
    • Confirms that valid PropagationPolicy objects are allowed through without errors.

  • Mutation webhook tests:

    • Handles decode errors and denies admission when decoding fails.
    • Provides full coverage of policy mutation with default values and patch application.

What type of PR is this?

/kind failing-test
/kind feature

Which issue(s) this PR fixes:
Part of #5491

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/feature Categorizes issue or PR as related to a new feature. labels Sep 7, 2024
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 7, 2024
@mohamedawnallah mohamedawnallah force-pushed the unitTestPropagationPolicy branch from da158d6 to 08dcbf6 Compare September 7, 2024 16:36
@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.42%. Comparing base (32c2ef7) to head (e2a3f59).
Report is 12 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5492      +/-   ##
==========================================
+ Coverage   31.70%   32.42%   +0.72%     
==========================================
  Files         643      643              
  Lines       44445    44473      +28     
==========================================
+ Hits        14090    14421     +331     
+ Misses      29325    28957     -368     
- Partials     1030     1095      +65
Flag Coverage Δ
unittests 32.42% <ø> (+0.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mohamedawnallah
Copy link
Contributor Author

Closing and reopening some flaky e2e test failures...

@mohamedawnallah mohamedawnallah force-pushed the unitTestPropagationPolicy branch from 08dcbf6 to b725a07 Compare September 8, 2024 19:58
@XiShanYongYe-Chang
Copy link
Member

Hi @mohamedawnallah, can you help squash the commits into one?

@mohamedawnallah mohamedawnallah force-pushed the unitTestPropagationPolicy branch from b725a07 to d0731b5 Compare September 9, 2024 13:16
@mohamedawnallah
Copy link
Contributor Author

Hi @XiShanYongYe-Chang, I've squashed commits here into one and all subsequent UT PRs :)

@mohamedawnallah
pkg/webhook: test PropagationPolicy
e2a3f59 
In this commit, we introduce unit tests for both the `ValidatingAdmission`
and `MutatingAdmission` webhooks for the `PropagationPolicy` resource.

The tests include:

- Validation webhook tests:
  - Tests how the webhook responds when decoding the request object fails.
  - Ensures that updates to the `SchedulerName` field are denied, as it should remain immutable.
  - Validates that changes to the `PropagationPolicyPermanentIDLabel` label and its absence in creation requests are correctly handled.
  - Confirms that valid `PropagationPolicy` objects are allowed through without errors.

- Mutation webhook tests:
  - Handles decode errors and denies admission when decoding fails.
  - Provides full coverage of policy mutation with default values and patch application.

Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
@mohamedawnallah mohamedawnallah force-pushed the unitTestPropagationPolicy branch from d0731b5 to e2a3f59 Compare September 10, 2024 03:39
XiShanYongYe-Chang
XiShanYongYe-Chang reviewed Sep 10, 2024
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2024
@karmada-bot karmada-bot merged commit ca1b2ce into karmada-io:master Sep 10, 2024
12 checks passed
This was referenced Sep 12, 2024
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiShanYongYe-Chang XiShanYongYe-Chang XiShanYongYe-Chang left review comments

@RainbowMango RainbowMango Awaiting requested review from RainbowMango

Assignees

@XiShanYongYe-Chang XiShanYongYe-Chang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mohamedawnallah @codecov-commenter @XiShanYongYe-Chang @karmada-bot