Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/search/backendstore: unit test store #5811

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mohamedawnallah
Copy link
Contributor

Description

In this commit, we unit test backend store in karmada search on init backendstore manager, add backendstore, delete backendstore, and on get backendstore operations in addition to testing the concurrent calls on those ops.

What type of PR is this?

Which issue(s) this PR fixes:
Part of #5491.

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 13, 2024
@mohamedawnallah mohamedawnallah force-pushed the unitTestBackendStoreKarmadaSearch branch 2 times, most recently from d4601f0 to 1d4b57c Compare November 16, 2024 01:38
@karmada-bot karmada-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 16, 2024
@mohamedawnallah mohamedawnallah force-pushed the unitTestBackendStoreKarmadaSearch branch from 1d4b57c to 89e2693 Compare November 16, 2024 01:39
@karmada-bot karmada-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 16, 2024
@mohamedawnallah mohamedawnallah force-pushed the unitTestBackendStoreKarmadaSearch branch from 89e2693 to 16c606f Compare November 16, 2024 02:37
@karmada-bot karmada-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 16, 2024
In this commit, we unit test backend store in karmada search
on init backendstore manager, add backendstore, delete backendstore,
and on get backendstore operations in addition to testing the concurrent
calls on those ops.

Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
@mohamedawnallah mohamedawnallah force-pushed the unitTestBackendStoreKarmadaSearch branch from 16c606f to 6ae64b2 Compare November 16, 2024 02:39
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ikaven1024 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 45.60%. Comparing base (3acc14c) to head (6ae64b2).
Report is 28 commits behind head on master.

Files with missing lines Patch % Lines
pkg/search/backendstore/opensearch.go 33.33% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5811      +/-   ##
==========================================
+ Coverage   45.56%   45.60%   +0.04%     
==========================================
  Files         658      658              
  Lines       53921    53923       +2     
==========================================
+ Hits        24567    24590      +23     
+ Misses      27750    27721      -29     
- Partials     1604     1612       +8     
Flag Coverage Δ
unittests 45.60% <50.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@XiShanYongYe-Chang
Copy link
Member

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants