Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/search/backendstore: unit test opensearch #5824

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mohamedawnallah
Copy link
Contributor

@mohamedawnallah mohamedawnallah commented Nov 16, 2024

Description

In this commit, we unit test opensearch backend store for karmada search aggregated apiserver as cache registry on creating new instance and getting/creating an index.

What type of PR is this?

Which issue(s) this PR fixes:
Part of #5491.
Depends on #5811.

Does this PR introduce a user-facing change?:

NONE

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xishanyongye-chang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 75.75758% with 8 lines in your changes missing coverage. Please review.

Project coverage is 45.73%. Comparing base (3acc14c) to head (9b82211).

Files with missing lines Patch % Lines
pkg/search/backendstore/opensearch.go 79.16% 5 Missing ⚠️
pkg/search/controller.go 33.33% 2 Missing ⚠️
pkg/util/testing/mock_opensearch.go 80.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5824      +/-   ##
==========================================
+ Coverage   45.56%   45.73%   +0.17%     
==========================================
  Files         658      659       +1     
  Lines       53921    53929       +8     
==========================================
+ Hits        24567    24664      +97     
+ Misses      27750    27663      -87     
+ Partials     1604     1602       -2     
Flag Coverage Δ
unittests 45.73% <75.75%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mohamedawnallah mohamedawnallah force-pushed the unitTestOpenSearchBackendStore branch from 9b82211 to 4375084 Compare November 16, 2024 01:52
In this commit, we unit test opensearch backend store for
karmada search aggregated apiserver as cache registry on creating
new instance and getting/creating an index.

Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
@mohamedawnallah mohamedawnallah force-pushed the unitTestOpenSearchBackendStore branch from 4375084 to c8fa9ec Compare November 16, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants