-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator/pkg/tasks/init: unit test rbac #5636
operator/pkg/tasks/init: unit test rbac #5636
Conversation
7305bd1
to
87e68cc
Compare
In this commit, we unit test rbac in the karmada init task operator package by checking that cluster roles and their associated cluster role bindings are created as expected. Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
87e68cc
to
6a83fe4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5636 +/- ##
==========================================
+ Coverage 39.09% 39.16% +0.06%
==========================================
Files 650 650
Lines 45209 45209
==========================================
+ Hits 17676 17705 +29
+ Misses 26180 26143 -37
- Partials 1353 1361 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cc @XiShanYongYe-Chang All test cases passed after rebasing on the master branch :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
In this commit, we unit test rbac in the karmada init task operator package by checking that cluster roles and their associated cluster role bindings are created as expected.
What type of PR is this?
Which issue(s) this PR fixes:
Part of #5491.
Dependency
This PR depends on #5630.
Does this PR introduce a user-facing change?: