Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator/pkg/tasks/init: unit test rbac #5636

Merged

Conversation

mohamedawnallah
Copy link
Contributor

@mohamedawnallah mohamedawnallah commented Oct 2, 2024

Description

In this commit, we unit test rbac in the karmada init task operator package by checking that cluster roles and their associated cluster role bindings are created as expected.

What type of PR is this?

Which issue(s) this PR fixes:
Part of #5491.

Dependency

This PR depends on #5630.

Does this PR introduce a user-facing change?:

NONE

In this commit, we unit test rbac in the karmada init task
operator package by checking that cluster roles and their associated
cluster role bindings are created as expected.

Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
@mohamedawnallah mohamedawnallah force-pushed the unitTestRBACInitTaskOperatorPkg branch from 87e68cc to 6a83fe4 Compare October 17, 2024 15:11
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.16%. Comparing base (0d55ead) to head (6a83fe4).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5636      +/-   ##
==========================================
+ Coverage   39.09%   39.16%   +0.06%     
==========================================
  Files         650      650              
  Lines       45209    45209              
==========================================
+ Hits        17676    17705      +29     
+ Misses      26180    26143      -37     
- Partials     1353     1361       +8     
Flag Coverage Δ
unittests 39.16% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mohamedawnallah
Copy link
Contributor Author

cc @XiShanYongYe-Chang All test cases passed after rebasing on the master branch :)

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2024
@karmada-bot karmada-bot merged commit a3005d7 into karmada-io:master Oct 21, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants