-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator/pkg/tasks/init: unit test wait #5657
operator/pkg/tasks/init: unit test wait #5657
Conversation
ac9cd3f
to
a933a6c
Compare
In this commit, we unit test wait init task on waiting for Karmada APIServer and Karmada Control Plane components. Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
a933a6c
to
04d073c
Compare
Rebased after merging #5624. I'll ask for a review once the GitHub CI tests are complete. :) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5657 +/- ##
==========================================
+ Coverage 37.75% 37.89% +0.13%
==========================================
Files 649 649
Lines 45133 45133
==========================================
+ Hits 17042 17105 +63
+ Misses 26795 26730 -65
- Partials 1296 1298 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
In this commit, we unit test wait init task on waiting for Karmada APIServer and Karmada Control Plane components.
What type of PR is this?
Which issue(s) this PR fixes:
Part of #5491.
Depends on #5624.
Does this PR introduce a user-facing change?: