-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/karmadactl/addons: unit test karmada search #5776
pkg/karmadactl/addons: unit test karmada search #5776
Conversation
In this commit, we unit test karmada search on status operation. Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
4012f88
to
91c4f92
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5776 +/- ##
==========================================
+ Coverage 42.33% 42.37% +0.03%
==========================================
Files 656 656
Lines 55871 55871
==========================================
+ Hits 23653 23674 +21
+ Misses 30699 30678 -21
Partials 1519 1519
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@XiShanYongYe-Chang All test cases passed now after #5765 got merged and rebased on master branch :) |
Thanks~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks~
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
In this commit, we unit test karmada search on status operation.
What type of PR is this?
Which issue(s) this PR fixes:
Part of #5491.
Depends on #5765.
Does this PR introduce a user-facing change?: