Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/karmadactl: unit test cordon #5829

Merged

Conversation

mohamedawnallah
Copy link
Contributor

Description

In this commit, we unit test cordon on karmadactl client making sure the cordon/uncordon working as expected on a given cluster.

What type of PR is this?

Which issue(s) this PR fixes:
Part of #5491.

Does this PR introduce a user-facing change?:

NONE

@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.43%. Comparing base (37ae460) to head (bdb9fb8).
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5829      +/-   ##
==========================================
+ Coverage   46.30%   46.43%   +0.12%     
==========================================
  Files         661      661              
  Lines       54308    54308              
==========================================
+ Hits        25147    25217      +70     
+ Misses      27536    27459      -77     
- Partials     1625     1632       +7     
Flag Coverage Δ
unittests 46.43% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

pkg/karmadactl/cordon/cordon_test.go Outdated Show resolved Hide resolved
pkg/karmadactl/cordon/cordon_test.go Show resolved Hide resolved
pkg/karmadactl/cordon/cordon_test.go Outdated Show resolved Hide resolved
@XiShanYongYe-Chang
Copy link
Member

/assign

In this commit, we unit test cordon on karmadactl client
making sure the cordon/uncordon working as expected on a given cluster.

Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~
/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2024
@karmada-bot karmada-bot merged commit 1202cc7 into karmada-io:master Dec 4, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants