-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/karmadactl: unit test cordon #5829
pkg/karmadactl: unit test cordon #5829
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5829 +/- ##
==========================================
+ Coverage 46.30% 46.43% +0.12%
==========================================
Files 661 661
Lines 54308 54308
==========================================
+ Hits 25147 25217 +70
+ Misses 27536 27459 -77
- Partials 1625 1632 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
/assign |
3a9513f
to
bd53309
Compare
In this commit, we unit test cordon on karmadactl client making sure the cordon/uncordon working as expected on a given cluster. Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
bd53309
to
bdb9fb8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks~
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
In this commit, we unit test cordon on karmadactl client making sure the cordon/uncordon working as expected on a given cluster.
What type of PR is this?
Which issue(s) this PR fixes:
Part of #5491.
Does this PR introduce a user-facing change?: