-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator/pkg/controlplane: unit test Metrics Adapter #5585
operator/pkg/controlplane: unit test Metrics Adapter #5585
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5585 +/- ##
==========================================
+ Coverage 39.02% 39.08% +0.06%
==========================================
Files 650 650
Lines 45207 45207
==========================================
+ Hits 17641 17670 +29
+ Misses 26207 26172 -35
- Partials 1359 1365 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
In this commit, we add unit tests for the metrics adapter controlplane pkg of the operator making sure that installing Karmada Metrics Adapter Deployment works as expect and its associated service. Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
a64b9d8
to
f9d9b09
Compare
cc @XiShanYongYe-Chang All tests cases passed now after rebasing :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
In this commit, we add unit tests for the metrics adapter controlplane pkg of the operator making sure that installing Karmada Metrics Adapter Deployment works as expect and its associated service.
What type of PR is this?
Which issue(s) this PR fixes:
Part of #5491
Does this PR introduce a user-facing change?: