pkg/webhook: unit test cluster override policy #5496
Conversation
karmada-bot
added
the
kind/failing-test
karmada-bot
added
kind/feature
In this commit, we add unit tests for the `ValidationAdmission` webhook specifically for the `ClusterOverridePolicy` resource. These tests ensure that the webhook correctly handles various admission scenarios: - Tests the behavior when decoding the request object fails, verifying that the admission is denied with an approriate error message. - Validates that the webhook denies admission when encountering invalid label values in the `ClusterOverridePolicy` spec, ensuring proper error messaging. - Confirms that valid `ClusterOverridePolicy` objects are admissionly allowed without errors. Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
mohamedawnallah
force-pushed
the
unitTestClusterOverridePolicy
branch
from
8bb5010 to
5a2e714
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5496 +/- ##
==========================================
+ Coverage 31.70% 31.72% +0.02%
==========================================
Files 643 643
Lines 44445 44445
==========================================
+ Hits 14090 14099 +9
+ Misses 29325 29315 -10
- Partials 1030 1031 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
Description
In this commit, we add unit tests for the
ValidationAdmissionwebhook specifically for theClusterOverridePolicyresource. These tests ensure that the webhook correctly handles various admission scenarios:ClusterOverridePolicyspec, ensuring proper error messaging.ClusterOverridePolicyobjects are admissionly allowed without errors.What type of PR is this?
/kind failing-test
/kind feature
Which issue(s) this PR fixes:
Part of #5491
Does this PR introduce a user-facing change?: