-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator/pkg/tasks/deinit: unit test cert #5643
operator/pkg/tasks/deinit: unit test cert #5643
Conversation
Hi @mohamedawnallah, can you help rebase the master branch? |
In this commit, we unit test the cert deinit task on the clean up operations. Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
2a50e38
to
2c7aea5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5643 +/- ##
==========================================
+ Coverage 37.18% 37.28% +0.09%
==========================================
Files 648 648
Lines 45091 45091
==========================================
+ Hits 16766 16810 +44
+ Misses 27052 27005 -47
- Partials 1273 1276 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cc @XiShanYongYe-Chang, I have rebased on the master branch, and all test cases have passed now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
In this commit, we unit test the cert deinit task on the clean up operations.
What type of PR is this?
Which issue(s) this PR fixes:
Part of #5491.
Depends on #5630.
Does this PR introduce a user-facing change?: