Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator/pkg/tasks/deinit: unit test cert #5643

Conversation

mohamedawnallah
Copy link
Contributor

@mohamedawnallah mohamedawnallah commented Oct 5, 2024

Description

In this commit, we unit test the cert deinit task on the clean up operations.

What type of PR is this?

Which issue(s) this PR fixes:
Part of #5491.
Depends on #5630.

Does this PR introduce a user-facing change?:

NONE

@XiShanYongYe-Chang
Copy link
Member

Hi @mohamedawnallah, can you help rebase the master branch?

In this commit, we unit test the cert deinit task on the
clean up operations.

Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
@mohamedawnallah mohamedawnallah force-pushed the unitTestCertDeInitTaskOperatorPkg branch from 2a50e38 to 2c7aea5 Compare October 12, 2024 04:23
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.28%. Comparing base (0f26e6e) to head (2c7aea5).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5643      +/-   ##
==========================================
+ Coverage   37.18%   37.28%   +0.09%     
==========================================
  Files         648      648              
  Lines       45091    45091              
==========================================
+ Hits        16766    16810      +44     
+ Misses      27052    27005      -47     
- Partials     1273     1276       +3     
Flag Coverage Δ
unittests 37.28% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mohamedawnallah
Copy link
Contributor Author

cc @XiShanYongYe-Chang, I have rebased on the master branch, and all test cases have passed now :)

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2024
@karmada-bot karmada-bot merged commit 201409c into karmada-io:master Oct 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants