pkg/webhook: unit test resource deletion protection #5499
Conversation
karmada-bot
added
the
kind/failing-test
karmada-bot
added
kind/feature
mohamedawnallah
force-pushed
the
unitTestResourceDeletionProtectionWebhook
branch
from
3e2c729 to
664f58a
Compare
In this commit, we add unit tests for the `ValidatingAdmission` validation webhook specifically for the resource deletion protection feature. These tests ensure that the webhook correctly handles various admission scenarios: - Tests the behavior when decoding the request object fails, verifying that admission is denied with an appropriate error message. - Ensures that resources labeled with `DeletionProtectionAlways` are denied deletion, validating that the error message is returned. - Confirms that resources without the deletion protection label are allowed to be deleted without errors. - Validates that resources with other labels are not impacted and are allowed to be deleted. - Confirms that non-delete operations (e.g., create) are allowed by default. Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
mohamedawnallah
force-pushed
the
unitTestResourceDeletionProtectionWebhook
branch
from
664f58a to
fa4a077
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5499 +/- ##
==========================================
+ Coverage 31.70% 31.73% +0.02%
==========================================
Files 643 643
Lines 44445 44445
==========================================
+ Hits 14090 14103 +13
+ Misses 29325 29312 -13
Partials 1030 1030
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
Description
In this commit, we add unit tests for the
ValidatingAdmissionvalidation webhook specifically for the resource deletion protection feature. These tests ensure that the webhook correctly handles various admission scenarios:DeletionProtectionAlwaysare denied deletion, validating that the error message is returned.What type of PR is this?
/kind failing-test
/kind feature
Which issue(s) this PR fixes:
Part of #5491
Does this PR introduce a user-facing change?: