Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/karmadactl: unit test promote #5895

Merged
merged 1 commit into from
Dec 3, 2024
Merged

pkg/karmadactl: unit test promote #5895

merged 1 commit into from
Dec 3, 2024

Conversation

mohamedawnallah
Copy link
Contributor

Description

In this commit, we unti test promoting a namespace-scoped or cluster-scoped resource in a legacy clsuter and validating the promote options on karmadactl command.

What type of PR is this?

Which issue(s) this PR fixes:
Part of #5491.

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 28, 2024
@mohamedawnallah mohamedawnallah mentioned this pull request Nov 28, 2024
Open
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 45.71429% with 19 lines in your changes missing coverage. Please review.

Project coverage is 47.24%. Comparing base (1bc955a) to head (6af9994).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
pkg/karmadactl/promote/promote.go 45.71% 19 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5895      +/-   ##
==========================================
+ Coverage   46.49%   47.24%   +0.75%     
==========================================
  Files         663      663              
  Lines       54740    54755      +15     
==========================================
+ Hits        25450    25871     +421     
+ Misses      27663    27192     -471     
- Partials     1627     1692      +65
Flag Coverage Δ
unittests 47.24% <45.71%> (+0.75%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@XiShanYongYe-Chang
Copy link
Member

Thanks~
/assign

@mohamedawnallah mohamedawnallah force-pushed the unitTestPromoteKarmadactl branch from 272a117 to 4da45c3 Compare December 2, 2024 03:59
XiShanYongYe-Chang
XiShanYongYe-Chang reviewed Dec 3, 2024
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other parts LGTM

pkg/karmadactl/promote/promote_test.go Outdated Show resolved Hide resolved
@mohamedawnallah mohamedawnallah force-pushed the unitTestPromoteKarmadactl branch from 4da45c3 to e5134b6 Compare December 3, 2024 03:05
@mohamedawnallah
pkg/karmadactl: unit test promote
6af9994 
In this commit, we unti test promoting a namespace-scoped or
cluster-scoped resource in a legacy clsuter and validating the promote
options on karmadactl command.

Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
@mohamedawnallah mohamedawnallah force-pushed the unitTestPromoteKarmadactl branch from e5134b6 to 6af9994 Compare December 3, 2024 03:27
XiShanYongYe-Chang
XiShanYongYe-Chang reviewed Dec 3, 2024
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2024
@karmada-bot karmada-bot merged commit eea14cb into karmada-io:master Dec 3, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiShanYongYe-Chang XiShanYongYe-Chang XiShanYongYe-Chang left review comments

@chaosi-zju chaosi-zju Awaiting requested review from chaosi-zju

@lonelyCZ lonelyCZ Awaiting requested review from lonelyCZ

Assignees

@XiShanYongYe-Chang XiShanYongYe-Chang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mohamedawnallah @codecov-commenter @XiShanYongYe-Chang @karmada-bot