Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize Tokenizer and simplify str_lookup prototype #491

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Initialize Tokenizer and simplify str_lookup prototype #491

wants to merge 1 commit into from
+36 −27

Conversation

pagakarthik
Copy link

  • new method to initialize tokenizer with a given vocab_size
  • removed voacb_size from the arguments of build_tokenizer
  • applied the changes in run.c, runq.c, test.c
  • pass the tokenizer object to str_lookup
  • helps to easily follow - "oh! we will be checking for the string in the Tokenizer"
  • makes it easy for future changes to sentencepiece code <I couldn't follow the TODO, so start with something simpe=le>
  • passes: unit test (test.c)
  • passes: integration test (./run stories15M.bin on Mackbook M1>

@pagakarthik
Initialize tokenizer and simplify str_lookup prototype
bffee1f 
- new method to initialize tokenizer with a given vocab_size
- removed voacb_size from the arguments of build_tokenizer
- applied the changes in run.c, runq.c, test.c
- pass the tokenizer object to str_lookup
- helps to easily follow - "oh! we will be checking for the string in the Tokenizer"
- passes: unit test (test.c)
- passes: integration test (./run stories15M.bin on Mackbook M1>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pagakarthik