Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize Tokenizer and simplify str_lookup prototype #491

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Initialize Tokenizer and simplify str_lookup prototype #491

wants to merge 1 commit into from

Commits on Feb 25, 2024

  1. Initialize tokenizer and simplify str_lookup prototype 

    - new method to initialize tokenizer with a given vocab_size
- removed voacb_size from the arguments of build_tokenizer
- applied the changes in run.c, runq.c, test.c
- pass the tokenizer object to str_lookup
- helps to easily follow - "oh! we will be checking for the string in the Tokenizer"
- passes: unit test (test.c)
- passes: integration test (./run stories15M.bin on Mackbook M1>
    @pagakarthik
    pagakarthik committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    bffee1f View commit details
    Browse the repository at this point in the history