Enhance BooleanColumn data rendering for grid export fixes #888

kartik-v · May 15, 2019 · 910e8f8 · 910e8f8
1 parent 6744723
commit 910e8f8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/CHANGE.md b/CHANGE.md
@@ -3,8 +3,9 @@ Change Log: `yii2-grid`
 
 ## Version 3.3.1
 
-**Date:** _under development_
+**Date:** 15-May-2019
 
+- (enh #901): Update Latvian Translations.
 - (bug #889): Correct nested expand row validation.
 - (enh #888): Enhance `BooleanColumn` data rendering for grid export.
 - (bug #885, #886): Fix for `CheckboxColumn::checkboxOptions` to be set as Closure.

diff --git a/src/BooleanColumn.php b/src/BooleanColumn.php
@@ -105,7 +105,7 @@ protected function getIconMarkup($type = 'true')
  return $label;
  }
  $isBs4 = $this->grid->isBs4();
- if ($type === 'false') {
+ if ($type === 'true') {
  return ($isBs4 ? GridView::ICON_ACTIVE_BS4 : GridView::ICON_ACTIVE) . 
  Html::tag('span', $this->trueLabel, ['class' => 'kv-grid-boolean']);
  }