Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken ExpandRow with only detail option(update 3.3.0 => 3.3.1) #909

Closed
s1lver opened this issue May 27, 2019 · 5 comments
Closed

Broken ExpandRow with only detail option(update 3.3.0 => 3.3.1) #909

s1lver opened this issue May 27, 2019 · 5 comments

Comments

@s1lver
Copy link
Contributor

s1lver commented May 27, 2019

After upgrading to 3.3.1, ExpandRow stops working if only the detail option is used. DetailUrl works in the same mode.
Rollback to version 3.3.0 - the problem disappeared.

@kartik-v
Copy link
Owner

Thanks for the report. Can you share your code for gridview configuration.

@s1lver
Copy link
Contributor Author

s1lver commented May 29, 2019

Thanks for the report. Can you share your code for gridview configuration.

<?= GridView::widget([
	'bootstrap' => true,
	'condensed' => true,
	'hover' => true,
	'summary' => false,
	'dataProvider' => $dataProvider,
	'panel' => false,
	'showPageSummary' => false,
	'export' => false,
	'toolbar' => false,
	'resizableColumns' => false,
	'hideResizeMobile' => false,
	'krajeeDialogSettings' => [
		'useNative' => true,
		'overrideYiiConfirm' => false,
		'showDraggable' => false
	],
	'containerOptions' => [
		'class' => 'overflow-none'
	],
	'columns' => [
		[
			'class' => ExpandRowColumn::class,
			'value' => function($key) {
				return ($key === Yii::$app->request->get('expand'))?GridView::ROW_EXPANDED:GridView::ROW_COLLAPSED;
			},
			'allowBatchToggle' => true,
			'detail' => function($model)  {
				return $this->render('view', [
					'model' => $model
				]);
			},
			'enableRowClick' => true,
			'expandOneOnly' => true,
			'detailAnimationDuration' => 0,
			'detailOptions' => ['class' => 'kv-state-enable']
		]
	]
]);

@stale
Copy link

stale bot commented Jul 28, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 28, 2019
@s1lver
Copy link
Contributor Author

s1lver commented Aug 2, 2019

Up

@stale stale bot removed the wontfix label Aug 2, 2019
@s1lver
Copy link
Contributor Author

s1lver commented Aug 9, 2019

"Expand all" button works, but single button broken

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants