Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

floatHeaderOptions 'scrollingTop' should be 'top' #922

Closed
arkurth opened this issue Aug 21, 2019 · 0 comments
Closed

floatHeaderOptions 'scrollingTop' should be 'top' #922

arkurth opened this issue Aug 21, 2019 · 0 comments
Labels

Comments

@arkurth
Copy link

arkurth commented Aug 21, 2019

This is a minor suggestion to update README.md and your docs.

floaThead no longer uses the scrollingTop option. It was renamed to top in version 1.3.1 and support for the parameter was removed at some point.

Specifying scrollingTop no longer has any effect on the placement of the header:

echo GridView::widget([
    'floatHeader'=>true,
    'floatHeaderOptions'=>[
        'scrollingTop'=>'100',
        'debug'=>true,
    ],
    ...
]);

The following appears in console.log with floaThead's debug option enabled:

jquery.floatThead.min.js:1 jQuery.floatThead: Used [scrollingTop] key to init plugin, but that param is not an option for the plugin. Valid options are: headerCellSelector, zIndex, position, top, bottom, scrollContainer, responsiveContainer, getSizingRow, floatTableClass, floatWrapperClass, floatContainerClass, copyTableClass, autoReflow, debug, support, floatContainerCss

Specifying top does cause the header to be positioned as intended:

echo GridView::widget([
    'floatHeader'=>true,
    'floatHeaderOptions'=>[
        'top'=>'100',
    ],
    ...
]);

Thanks for all your great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants