Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

CI lint issues because golangci-lint is updated to v1.16.0 #527

Closed
teawater opened this issue Apr 9, 2019 · 3 comments
Closed

CI lint issues because golangci-lint is updated to v1.16.0 #527

teawater opened this issue Apr 9, 2019 · 3 comments

Comments

@teawater
Copy link
Member

teawater commented Apr 9, 2019

kata-containers/tests#1427
teawater added a commit to teawater/agent that referenced this issue Apr 9, 2019
@teawater
ci: Update travis go version from 1.10 to 1.11
828b417 
Update go version because golangci-lint v1.16.0 cannot work OK with go 1.10.

Fixes: kata-containers#527

Signed-off-by: Hui Zhu <teawater@hyper.sh>
@teawater teawater mentioned this issue Apr 9, 2019
Merged
@teawater
Copy link
Member Author

teawater commented Apr 9, 2019 

/home/travis/gopath/src/github.com/kata-containers/agent
/home/travis/gopath/src/github.com/kata-containers/agent/pkg/types
/home/travis/gopath/src/github.com/kata-containers/agent/pkg/uevent
/home/travis/gopath/src/github.com/kata-containers/agent/protocols/client
/home/travis/gopath/src/github.com/kata-containers/agent/protocols/grpc
/home/travis/gopath/src/github.com/kata-containers/agent/protocols/mockserver
grpc_test.go:872:3: composites: `github.com/kata-containers/agent/vendor/github.com/opencontainers/runc/libcontainer/configs.Rlimit` composite literal uses unkeyed fields (govet)
		{unix.RLIMIT_CPU, 100, 120},
		^
grpc_test.go:873:3: composites: `github.com/kata-containers/agent/vendor/github.com/opencontainers/runc/libcontainer/configs.Rlimit` composite literal uses unkeyed fields (govet)
		{unix.RLIMIT_FSIZE, 100, 120},
		^
grpc_test.go:874:3: composites: `github.com/kata-containers/agent/vendor/github.com/opencontainers/runc/libcontainer/configs.Rlimit` composite literal uses unkeyed fields (govet)
		{unix.RLIMIT_DATA, 100, 120},
		^
grpc_test.go:891:3: composites: `github.com/kata-containers/agent/vendor/github.com/opencontainers/runtime-spec/specs-go.POSIXRlimit` composite literal uses unkeyed fields (govet)
		{"RLIMIT_CPU", 100, 120},
		^
grpc_test.go:892:3: composites: `github.com/kata-containers/agent/vendor/github.com/opencontainers/runtime-spec/specs-go.POSIXRlimit` composite literal uses unkeyed fields (govet)
		{"RLIMIT_FSIZE", 100, 120},
		^
grpc_test.go:893:3: composites: `github.com/kata-containers/agent/vendor/github.com/opencontainers/runtime-spec/specs-go.POSIXRlimit` composite literal uses unkeyed fields (govet)
		{"RLIMIT_DATA", 100, 120},
		^
The command ".ci/static-checks.sh" failed and exited with 1 during .
Your build has been stopped.

@bergwolf
Copy link
Member

bergwolf commented Apr 9, 2019

Maybe we should create a docker image containing all the golang static checkers so that their versions are managed by ourselves.

@teawater
Copy link
Member Author

teawater commented Apr 9, 2019

Maybe we should create a docker image containing all the golang static checkers so that their versions are managed by ourselves.

We have version control for golangci-lint in test now.
https://github.com/kata-containers/tests/blob/0c8be9468395da61ec4ea672bdc003be8a10a350/versions.yaml#L55

teawater added a commit to teawater/agent that referenced this issue Apr 9, 2019
@teawater
lint: Update code to handle lint issues
c2e0437 
Update code to handle lint issues after golangci-lint update to v1.6.0.

Fixes: kata-containers#527

Signed-off-by: Hui Zhu <teawater@hyper.sh>
teawater added a commit to teawater/agent that referenced this issue Apr 9, 2019
@teawater
lint: Update code to handle lint issues
860da8f 
Update code to handle lint issues after golangci-lint update to v1.6.0.

Fixes: kata-containers#527

Signed-off-by: Hui Zhu <teawater@hyper.sh>
teawater added a commit to teawater/agent that referenced this issue Apr 9, 2019
@teawater
lint: Update code to handle lint issues
d815c97 
Update code to handle lint issues after golangci-lint update to v1.6.0.

Fixes: kata-containers#527

Signed-off-by: Hui Zhu <teawater@hyper.sh>
teawater added a commit to teawater/agent that referenced this issue Apr 9, 2019
@teawater
travis: Use xenial
01b1cb2 
Using xenial to handle the issue that using trusty in travis and go 1.11.7.

Fixes: kata-containers#527

Signed-off-by: Hui Zhu <teawater@hyper.sh>
ganeshmaharaj pushed a commit to ganeshmaharaj/agent that referenced this issue Apr 16, 2019
@chavafg
golang: Merge pull request kata-containers#528 from teawater/lint
200d8e4 
Update code to handle lint issues after golangci-lint update to v1.6.0
(cherry picked from commit 801d792)

Fixes: kata-containers#527

Signed-off-by: Ganesh Maharaj Mahalingam <ganesh.mahalingam@intel.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bergwolf @teawater