This repository has been archived by the owner on May 12, 2021. It is now read-only.
Update code to handle lint issues after golangci-lint update to v1.6.0 #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update go version because golangci-lint v1.16.0 cannot work OK with go 1.10. Fixes: kata-containers#527 Signed-off-by: Hui Zhu <teawater@hyper.sh>
|
To fix lint issues in #526 |
teawater
changed the title
Update code to handle lint issues after golangci-lint update to v1.6.0. Fixes: kata-containers#527 Signed-off-by: Hui Zhu <teawater@hyper.sh>
|
/test |
|
Travis still failing, but that is due to the same golang binary issue as kata-containers/runtime#1506 I think? |
Using xenial to handle the issue that using trusty in travis and go 1.11.7. Fixes: kata-containers#527 Signed-off-by: Hui Zhu <teawater@hyper.sh>
|
/test |
Done. |
bergwolf
approved these changes
Apr 9, 2019
grahamwhaley
reviewed
Apr 9, 2019
There was a problem hiding this comment.
l g t m
but I'd like to hear from @chavafg if we can before we land it.
devimc
approved these changes
Apr 9, 2019
chavafg
approved these changes
Apr 9, 2019
ganeshmaharaj
pushed a commit
to ganeshmaharaj/agent
that referenced
this pull request
Apr 16, 2019
Update code to handle lint issues after golangci-lint update to v1.6.0 (cherry picked from commit 801d792) Fixes: kata-containers#527 Signed-off-by: Ganesh Maharaj Mahalingam <ganesh.mahalingam@intel.com>
katacontainersbot
pushed a commit
to katacontainersbot/agent
that referenced
this pull request
Apr 17, 2019
- backport: 1.6.2 backport patches ccc8b26 lint: Merge pull request kata-containers#491 from ganeshmaharaj/go-linter-change 200d8e4 golang: Merge pull request kata-containers#528 from teawater/lint d1ace1b license: Merge pull request kata-containers#532 from jcvenegas/stable-1.5-fix-travis 0dbf85d agent: Merge pull request kata-containers#526 from lifupan/stopfix Signed-off-by: katacontainers bot <katacontainersbot@katacontainers.io>
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update go version because golangci-lint v1.16.0 cannot work OK with go 1.10.
Fixes: #527
Signed-off-by: Hui Zhu teawater@hyper.sh