Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

backport: 1.6.2 backport patches #534

Merged
merged 4 commits into from
Apr 17, 2019
Merged

backport: 1.6.2 backport patches #534

merged 4 commits into from
Apr 17, 2019

Conversation

ganeshmaharaj
Copy link
Contributor

@ganeshmaharaj ganeshmaharaj commented Apr 16, 2019 •
edited
Loading

Backports include the below changes.

#526
#532
#528
#491

teawater and others added 2 commits April 16, 2019 14:29
@teawater
agent: Merge pull request kata-containers#526 from lifupan/stopfix
0dbf85d 
agent: send SIGKILL instead of SIGTERM to container init process
(cherry picked from commit c624f63)

Fixes:kata-containers#525

Signed-off-by: Ganesh Maharaj Mahalingam <ganesh.mahalingam@intel.com>
@chavafg
license: Merge pull request kata-containers#532 from jcvenegas/stable…
d1ace1b 
…-1.5-fix-travis

license: add license header
(cherry picked from commit 741fdb9)

Fixes: kata-containers#531

Signed-off-by: Ganesh Maharaj Mahalingam <ganesh.mahalingam@intel.com>
chavafg and others added 2 commits April 16, 2019 16:16
@chavafg
golang: Merge pull request kata-containers#528 from teawater/lint
200d8e4 
Update code to handle lint issues after golangci-lint update to v1.6.0
(cherry picked from commit 801d792)

Fixes: kata-containers#527

Signed-off-by: Ganesh Maharaj Mahalingam <ganesh.mahalingam@intel.com>
lint: Merge pull request kata-containers#491 from ganeshmaharaj/go-li…
ccc8b26 
…nter-change

lint: Switch golang linter to golangci-lint
(cherry picked from commit 02cacde)

Fixes kata-containers#494

Signed-off-by: Ganesh Maharaj Mahalingam <ganesh.mahalingam@intel.com>
@ganeshmaharaj
Copy link
Contributor Author

/test

jodh-intel
jodh-intel approved these changes Apr 17, 2019
View reviewed changes
Copy link
Contributor

@jodh-intel jodh-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought those commits where merge commits originally, but can see now that they aren't, so...

@ganeshmaharaj
Copy link
Contributor Author

Power8 ubuntu failed with below errors

ERROR: Cannot delete workspace: Unable to delete '/home/jenkins/workspace/kata-containers-agent-Power8-ubuntu-16-04-PR-initrd/go/pkg/linux_ppc64le/github.com/kata-containers/tests/vendor/github.com/BurntSushi/toml.a'. Tried 3 times (of a maximum of 3) waiting 0.1 sec between attempts.
Performing Post build task...
Match found for :.* : True

vsocks build failed with

# time="2019-04-17 07:13:22.783492234Z" level=info msg="About to del CNI network crionet (type=bridge)" 
# time="2019-04-17 07:13:23.919444517Z" level=debug msg="event: "/var/run/crio/exits/15566274909acd2a564de3552eda1abcd6663448a474a61611b81eaeec1867d8.A2JG0Z": RENAME" 
# time="2019-04-17 07:13:23.919511317Z" level=debug msg="event: "/var/run/crio/exits/15566274909acd2a564de3552eda1abcd6663448a474a61611b81eaeec1867d8": CREATE" 
# time="2019-04-17 07:13:23.919520917Z" level=debug msg="container or sandbox exited: 15566274909acd2a564de3552eda1abcd6663448a474a61611b81eaeec1867d8" 
# time="2019-04-17 07:13:23.919546517Z" level=debug msg="sandbox exited and found: 15566274909acd2a564de3552eda1abcd6663448a474a61611b81eaeec1867d8" 
# time="2019-04-17 07:13:24.754494445Z" level=debug msg="unmounted container "15566274909acd2a564de3552eda1abcd6663448a474a61611b81eaeec1867d8"" 
# time="2019-04-17 07:13:24.754571745Z" level=debug msg="StopPodSandboxResponse 15566274909acd2a564de3552eda1abcd6663448a474a61611b81eaeec1867d8: &StopPodSandboxResponse{}" 
# Stopped sandbox 15566274909acd2a564de3552eda1abcd6663448a474a61611b81eaeec1867d8
# time="2019-04-17 07:13:24.763803178Z" level=debug msg="RemovePodSandboxRequest &RemovePodSandboxRequest{PodSandboxId:15566274909acd2a564de3552eda1abcd6663448a474a61611b81eaeec1867d8,}" 
# time="2019-04-17 07:13:24.809412438Z" level=debug msg="Failed to unmount 5c4f6e20750cf8188310130934f10cb6e1e1b7e301a7bd00f8144d377cc69aca overlay: /tmp/tmp.O5Hg9WZrCA/crio/overlay/5c4f6e20750cf8188310130934f10cb6e1e1b7e301a7bd00f8144d377cc69aca/merged - invalid argument" 
# time="2019-04-17 07:13:24.847987273Z" level=debug msg="unmounted container "15566274909acd2a564de3552eda1abcd6663448a474a61611b81eaeec1867d8"" 
# time="2019-04-17 07:13:24.912303498Z" level=debug msg="RemovePodSandboxResponse &RemovePodSandboxResponse{}" 
# Removed sandbox 15566274909acd2a564de3552eda1abcd6663448a474a61611b81eaeec1867d8
# time="2019-04-17 07:13:24.914445206Z" level=debug msg="Caught SIGTERM"

@jcvenegas jcvenegas merged commit 853d95b into kata-containers:stable-1.6 Apr 17, 2019
@grahamwhaley
Copy link
Contributor

power8 feels like something has gotten stuck with a file open. @nitkon - any thoughts, or maybe a reboot is in order.
Having said that, I just went to look at the power8 CI slave build history:
http://jenkins.katacontainers.io/computer/Power8_slave01/builds
It looks to me like we have not had a good build for 1 month and 18 days.
@nitkon - are you able to find resource to fix/maintain this? If not, I think it's heading to be disabled.

thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jcvenegas jcvenegas jcvenegas approved these changes

@jodh-intel jodh-intel jodh-intel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ganeshmaharaj @grahamwhaley @jodh-intel @jcvenegas @teawater @chavafg