CI: Require pullapprove ack for protocol changes #176
Conversation
jodh-intel
force-pushed
the
pullapprove-for-grpc-changes
branch
from
e8bd995 to
7cdd77f
Compare
|
We might want to tweak the list of teams I've added here. Here's my rationale for the currently listed team for this change:
|
|
LGTM |
.pullapprove.yml
Outdated
| @@ -41,3 +41,16 @@ groups: | |||
| - "*.md" | |||
| exclude: | |||
| - "vendor/*" | |||
|
|
|||
| protocol-changes: | |||
| required: 1 | |||
There was a problem hiding this comment.
required: 1 feels a little slim to me - if it is architectural change then I would not be against increasing this .
There was a problem hiding this comment.
Oh yeah I've missed that actually. @jodh-intel could you please put 2 or 3 here ?
I think 2 is already the default for the agent repo, isn't it ?
There was a problem hiding this comment.
Ha - I put in 1 as I was expecting folk to fight against >1 ;)
I''ve now changed it to 2. The ideal in my mind would be 1 from the arch team and 1 from one of the other two teams. However, fwics, that would require a bit of extra bloat in the config as we'd need two "protocol-changes" groups - one just for the arch team and another for the other two teams.
There was a problem hiding this comment.
2 is fine for now, we'll introduce protocol-changes group in a follow-up PR I guess
A change to any of the gRPC protocol buffer files (`*.proto`) should require two additional approvals due to the potential impact it could have across the system. Fixes kata-containers#175. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
jodh-intel
force-pushed
the
pullapprove-for-grpc-changes
branch
from
7cdd77f to
5e6c385
Compare
|
LGTM |
A change to any of the gRPC protocol buffer files (
*.proto) shouldrequire an additional approval due to the potential impact it could
have across the system.
Fixes #175.
Signed-off-by: James O. D. Hunt james.o.hunt@intel.com