Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

CI: Pin Travis golang version #282

Merged

Conversation

jodh-intel
Copy link
Contributor

Travis appears to be providing a version of golang that is too old for
https://mvdan.cc/xurls/cmd/xurls, which is used by the CI scripts in the
tests repo.

See:

Fixes #281.

Signed-off-by: James O. D. Hunt james.o.hunt@intel.com

@jodh-intel
Copy link
Contributor Author

It's unclear whether you can just specify a go version in .travis.yml or whether you need to set the project language to go too:

Let's see what happens...

@jodh-intel jodh-intel force-pushed the ci-set-travis-golang-version branch 4 times, most recently from 7dbfe64 to 558dd7c Compare October 23, 2018 16:14
Travis appears to be providing a version of golang that is too old for
https://mvdan.cc/xurls/cmd/xurls, which is used by the CI scripts in the
tests repo.

See:

- kata-containers/runtime#744
- kata-containers/tests#843 (comment)

Required adding a NOP makefile to avoid Travis from trying to build
this repo using `go`.

Fixes kata-containers#281.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
@jodh-intel jodh-intel force-pushed the ci-set-travis-golang-version branch from 3de1f97 to b40b9ff Compare October 23, 2018 16:26
@grahamwhaley
Copy link
Contributor

green @jodh-intel !

@jodh-intel
Copy link
Contributor Author

Tis, but I don't see any acks?!? Pretty please... :)

Copy link
Contributor

@grahamwhaley grahamwhaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, Makefile!
lgtm

@jodh-intel jodh-intel merged commit 0215c83 into kata-containers:master Oct 23, 2018
@jodh-intel
Copy link
Contributor Author

Ta! ;)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants