This repository has been archived by the owner on May 12, 2021. It is now read-only.
Rename GetOCISpec #2252
Assignees
Labels
Comments
devimc
added
enhancement
devimc
pushed a commit
to devimc/kata-runtime
that referenced
this issue
Nov 22, 2019
GetOCISpec returns a patched version of the original OCI spec, it was modified to support: * capabilities * Ephemeral storage * k8s empty dir In order to avoid consusions and make api clear, rename GetOCISpec to GetPatchedOCISpec. fixes kata-containers#2252 Signed-off-by: Julio Montes <julio.montes@intel.com>
devimc
pushed a commit
to devimc/kata-runtime
that referenced
this issue
Nov 22, 2019
GetOCISpec returns a patched version of the original OCI spec, it was modified to support: * capabilities * Ephemeral storage * k8s empty dir In order to avoid consusions and make api clear, rename GetOCISpec to GetPatchedOCISpec. fixes kata-containers#2252 Signed-off-by: Julio Montes <julio.montes@intel.com>
devimc
pushed a commit
to devimc/kata-runtime
that referenced
this issue
Nov 22, 2019
GetOCISpec returns a patched version of the original OCI spec, it was modified to support: * capabilities * Ephemeral storage * k8s empty dir In order to avoid consusions and make api clear, rename GetOCISpec to GetPatchedOCISpec. fixes kata-containers#2252 Signed-off-by: Julio Montes <julio.montes@intel.com>
devimc
pushed a commit
to devimc/kata-runtime
that referenced
this issue
Nov 22, 2019
GetOCISpec returns a patched version of the original OCI spec, it was modified to support: * capabilities * Ephemeral storage * k8s empty dir In order to avoid consusions and make api clear, rename GetOCISpec to GetPatchedOCISpec. fixes kata-containers#2252 Signed-off-by: Julio Montes <julio.montes@intel.com>
devimc
pushed a commit
to devimc/kata-runtime
that referenced
this issue
Nov 25, 2019
GetOCISpec returns a patched version of the original OCI spec, it was modified to support: * capabilities * Ephemeral storage * k8s empty dir In order to avoid consusions and make api clear, rename GetOCISpec to GetPatchedOCISpec and ContainerConfig.Spec to ContainerConfig.CustomSpec fixes kata-containers#2252 Signed-off-by: Julio Montes <julio.montes@intel.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
When I was debugging an issue in kata-runtime, it was difficult to realize that
GetOCISpecmethod returns a patched version of the original spec, to avoid confusions we should rename it to something less genericThe text was updated successfully, but these errors were encountered: