This repository has been archived by the owner on May 12, 2021. It is now read-only.
virtcontainers: rename GetOCISpec to GetPatchedOCISpec #2253
+43
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devimc
force-pushed
the
topic/virtcontainers/GetPatchedOCI
branch
from
cfa642d to
3e5f70c
Compare
|
/test-ubuntu |
devimc
force-pushed
the
topic/virtcontainers/GetPatchedOCI
branch
from
3e5f70c to
5055463
Compare
|
/test-ubuntu |
GetOCISpec returns a patched version of the original OCI spec, it was modified to support: * capabilities * Ephemeral storage * k8s empty dir In order to avoid consusions and make api clear, rename GetOCISpec to GetPatchedOCISpec and ContainerConfig.Spec to ContainerConfig.CustomSpec fixes kata-containers#2252 Signed-off-by: Julio Montes <julio.montes@intel.com>
devimc
force-pushed
the
topic/virtcontainers/GetPatchedOCI
branch
from
5055463 to
613fd0f
Compare
|
/test-ubuntu |
|
Thanks @devimc |
Codecov Report
@@ Coverage Diff @@
## master #2253 +/- ##
=========================================
Coverage ? 48.76%
=========================================
Files ? 111
Lines ? 16086
Branches ? 0
=========================================
Hits ? 7845
Misses ? 7266
Partials ? 975 |
amshinde
approved these changes
Nov 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetOCISpec returns a patched version of the original OCI spec, it was modified
to support:
In order to avoid consusions and make api clear, rename GetOCISpec
to GetPatchedOCISpec.
fixes #2252
Signed-off-by: Julio Montes julio.montes@intel.com