Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

DESTDIR is ignored #337

Closed
bergwolf opened this issue May 23, 2018 · 5 comments
Closed

DESTDIR is ignored #337

bergwolf opened this issue May 23, 2018 · 5 comments

Comments

@bergwolf
Copy link
Member

Description of problem

make install DESTDIR=${foobar} is supposed to install all artifacts in dest dir ${foobar}.

Expected result

All artifacts are installed under ${foobar}

Actual result

Only kata-collect-data.sh is installed at ${foobar}

@bergwolf
Copy link
Member Author

Do we want DESTDIR at all? I'm not sure... The fact that everything works without it, might be an evidence that we don't need it at all.

/cc @jodh-intel

@jodh-intel
Copy link
Contributor

You're right - it seems broken. We don't use that variable currently for the packaging:

... so I agree, we could either remove it or make it work ;)

@sboeuf
Copy link

sboeuf commented May 24, 2018

I am always in favor of removing things if we don't need them :)

@WeiZhang555
Copy link
Member

#402 is trying resolve this issue.

@caoruidong
Copy link
Member

Since #402 is merged, close this issue.

zklei pushed a commit to zklei/runtime that referenced this issue Jun 13, 2019
So that we know for sure nothing is using the yamux channel before
returning success in close.

Fixes: kata-containers#337

Signed-off-by: Peng Tao <bergwolf@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants