This repository has been archived by the owner on May 12, 2021. It is now read-only.
make DESTDIR=/foo install is not honored. #401
Labels
duplicate
Same issue as one already reported
Comments
jcvenegas
added a commit
to jcvenegas/runtime
that referenced
this issue
Jun 14, 2018
Modify Makefile to use DESTDIR.
make install DESTDIR=/tmp/dest/
Before:
$tree /tmp/dest/
/tmp/dest/
└── usr
├── bin
│ └── kata-collect-data.sh
└── share
└── defaults
└── kata-containers
└── configuration.toml
5 directories, 2 files
Now:
$tree /tmp/dest/
/tmp/dest/
└── usr
└── local
├── bin
│ ├── kata-collect-data.sh
│ └── kata-runtime
└── share
└── bash-completion
└── completions
└── kata-runtime
Fixes: kata-containers#401
Signed-off-by: Jose Carlos Venegas Munoz <jose.carlos.venegas.munoz@intel.com>
jcvenegas
added a commit
to jcvenegas/runtime
that referenced
this issue
Jun 15, 2018
1. Fix config installation not exec permission is needed.
2. Makefile install all in DESTDIR.
make install DESTDIR=/tmp/dest/
Before:
$tree /tmp/dest/
/tmp/dest/
└── usr
├── bin
│ └── kata-collect-data.sh
└── share
└── defaults
└── kata-containers
└── configuration.toml
5 directories, 2 files
Now:
$tree /tmp/dest/
/tmp/dest/
└── usr
└── local
├── bin
│ ├── kata-collect-data.sh
│ └── kata-runtime
└── share
├── bash-completion
│ └── completions
│ └── kata-runtime
└── defaults
└── kata-containers
└── configuration.toml
Now the runtime when installed from source will instal the config file in /usr/local/...
See:
[Runtime.Config]
Path = "/usr/local/share/defaults/kata-containers/configuration.toml"
Fixes: kata-containers#401
Signed-off-by: Jose Carlos Venegas Munoz <jose.carlos.venegas.munoz@intel.com>
|
Duplicate of #337 I don't have strong opinion on removing it or making it work, so either is OK for me. |
|
Let me close this and discuss more in previous thread #337 |
jcvenegas
added a commit
to jcvenegas/runtime
that referenced
this issue
Jun 18, 2018
1. Fix config installation not exec permission is needed.
2. Makefile install all in DESTDIR.
make install DESTDIR=/tmp/dest/
Before:
$tree /tmp/dest/
/tmp/dest/
└── usr
├── bin
│ └── kata-collect-data.sh
└── share
└── defaults
└── kata-containers
└── configuration.toml
5 directories, 2 files
Now:
$tree /tmp/dest/
/tmp/dest/
└── usr
├── local
│ └── bin
│ ├── kata-collect-data.sh
│ └── kata-runtime
└── share
├── bash-completion
│ └── completions
│ └── kata-runtime
└── defaults
└── kata-containers
└── configuration.toml
Fixes: kata-containers#401
Signed-off-by: Jose Carlos Venegas Munoz <jose.carlos.venegas.munoz@intel.com>
jcvenegas
added a commit
to jcvenegas/runtime
that referenced
this issue
Jun 18, 2018
1. Fix config installation not exec permission is needed.
2. Makefile install all in DESTDIR.
make install DESTDIR=/tmp/dest/
Before:
$tree /tmp/dest/
/tmp/dest/
└── usr
├── bin
│ └── kata-collect-data.sh
└── share
└── defaults
└── kata-containers
└── configuration.toml
5 directories, 2 files
Now:
$tree /tmp/dest/
/tmp/dest/
└── usr
├── local
│ └── bin
│ ├── kata-collect-data.sh
│ └── kata-runtime
└── share
├── bash-completion
│ └── completions
│ └── kata-runtime
└── defaults
└── kata-containers
└── configuration.toml
Fixes: kata-containers#401
Signed-off-by: Jose Carlos Venegas Munoz <jose.carlos.venegas.munoz@intel.com>
jcvenegas
added a commit
to jcvenegas/runtime
that referenced
this issue
Jun 18, 2018
1. Fix config installation not exec permission is needed.
2. Makefile install all in DESTDIR.
make install DESTDIR=/tmp/dest/
Before:
$tree /tmp/dest/
/tmp/dest/
└── usr
├── bin
│ └── kata-collect-data.sh
└── share
└── defaults
└── kata-containers
└── configuration.toml
5 directories, 2 files
Now:
$tree /tmp/dest/
/tmp/dest/
└── usr
├── local
│ └── bin
│ ├── kata-collect-data.sh
│ └── kata-runtime
└── share
├── bash-completion
│ └── completions
│ └── kata-runtime
└── defaults
└── kata-containers
└── configuration.toml
Fixes: kata-containers#401
Signed-off-by: Jose Carlos Venegas Munoz <jose.carlos.venegas.munoz@intel.com>
jcvenegas
added a commit
to jcvenegas/runtime
that referenced
this issue
Jun 20, 2018
1. Fix config installation not exec permission is needed.
2. Makefile install all in DESTDIR.
make install DESTDIR=/tmp/dest/
Before:
$tree /tmp/dest/
/tmp/dest/
└── usr
├── bin
│ └── kata-collect-data.sh
└── share
└── defaults
└── kata-containers
└── configuration.toml
5 directories, 2 files
Now:
$tree /tmp/dest/
/tmp/dest/
└── usr
├── local
│ └── bin
│ ├── kata-collect-data.sh
│ └── kata-runtime
└── share
├── bash-completion
│ └── completions
│ └── kata-runtime
└── defaults
└── kata-containers
└── configuration.toml
Fixes: kata-containers#401
Signed-off-by: Jose Carlos Venegas Munoz <jose.carlos.venegas.munoz@intel.com>
zklei
pushed a commit
to zklei/runtime
that referenced
this issue
Jun 13, 2019
The Interface structure needs a new field 'type' so that we can properly determine the type of interface being described. This will be helpful for network hotplug, as it will be used to create the appropriate connection between the VM and the interface. Depends-on: github.com/kata-containers#858 Fixes kata-containers#401 Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
lifupan
pushed a commit
to lifupan/kata-runtime
that referenced
this issue
Aug 5, 2020
When checking if a device is an emulated vhost-user-blk or vhost-user-scsi one, we should not only check for their major number but also their device node type. They must be block devices. Fixes: kata-containers#401 Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description of problem
When
make install DESTDIR=/tmp/destis used not all is installed in/tmp/destExpected result
Install all under
/tmp/destActual result
The text was updated successfully, but these errors were encountered: