Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

SPDX: update cli and arch files to use SPDX #226

Merged

Conversation

grahamwhaley
Copy link
Contributor

Many cli and arch files were using the 'older style' fairly full
Apache license text. The project standard is the shorter SPDX style.
Convert them over.

Fixes: #225

Signed-off-by: Graham whaley graham.whaley@intel.com

Many cli and arch files were using the 'older style' fairly full
Apache license text. The project standard is the shorter SPDX style.
Convert them over.

Fixes: kata-containers#225

Signed-off-by: Graham whaley <graham.whaley@intel.com>
@jcvenegas
Copy link
Member

lgtm

@codecov
Copy link

codecov bot commented Apr 17, 2018

Codecov Report

Merging #226 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #226      +/-   ##
==========================================
- Coverage   65.33%   65.26%   -0.08%     
==========================================
  Files          73       74       +1     
  Lines        7709     7730      +21     
==========================================
+ Hits         5037     5045       +8     
- Misses       2128     2135       +7     
- Partials      544      550       +6
Impacted Files Coverage Δ
cli/list.go 88.38% <ø> (ø) ⬆️
cli/kata-env.go 100% <ø> (ø) ⬆️
cli/main.go 92.37% <ø> (ø) ⬆️
cli/utils.go 100% <ø> (ø) ⬆️
cli/logger.go 100% <ø> (ø) ⬆️
cli/pause.go 100% <ø> (ø) ⬆️
cli/run.go 94.11% <ø> (ø) ⬆️
cli/console.go 88.88% <ø> (ø) ⬆️
cli/kata-check_amd64.go 93.75% <ø> (ø) ⬆️
cli/exit.go 100% <ø> (ø) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 427b97c...e757a59. Read the comment docs.

@bergwolf
Copy link
Member

bergwolf commented Apr 18, 2018

lgtm!

Approved with PullApprove

@bergwolf
Copy link
Member

@jodh-intel PTAL and merge if it's OK to you. Let's ignore the codecov/project error since it is just license change.

@grahamwhaley
Copy link
Contributor Author

Oh, yeah, I meant to mention the codecov. I don't really understand how it went down!
@jodh-intel, @sboeuf - do we know how reproducible the codecov results are (you would think very...?) - maybe we need to set a small 'acceptable change' level on them, if we can.

@jodh-intel
Copy link
Contributor

Looking at codecov is on my todo list, but alas it isn't near to top ;)

Let's merge this thing!

@jodh-intel jodh-intel merged commit 3066368 into kata-containers:master Apr 18, 2018
@jodh-intel jodh-intel removed the review label Apr 18, 2018
zklei pushed a commit to zklei/runtime that referenced this pull request Jun 13, 2019
By storing the network information such as routes as pointers, we
end up having issues if we try to remove some elements from the list
as at the same time this list is parsed through by a loop.

For interfaces, we can use maps instead, because we have a way to
keep track of them based on their names. Maps are safer and allow
to keep pointers in this case.

In both cases, routes and interfaces list can be modified properly
while we loop over every items.

Fixes kata-containers#226

Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants