Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

license: SPDX: update all vc files to use SPDX style #231

Merged
merged 1 commit into from
Apr 18, 2018

Conversation

grahamwhaley
Copy link
Contributor

When imported, the vc files carried in the 'full style' apache
license text, but the standard for kata is to use SPDX style.
Update the relevant files to SPDX.

Fixes: #227

Signed-off-by: Graham whaley graham.whaley@intel.com

When imported, the vc files carried in the 'full style' apache
license text, but the standard for kata is to use SPDX style.
Update the relevant files to SPDX.

Fixes: kata-containers#227

Signed-off-by: Graham whaley <graham.whaley@intel.com>
@grahamwhaley
Copy link
Contributor Author

We'd like to land this ASAP, as due to PR kata-containers/tests#242, all pending PRs that have touched a vc file with the old copyright will now fail the CI.
Even with this PR, those pending PRs will need rebasing and pushing, but that is easier than forcing the developers to now update the licenses only in the files they have touched etc.

Related, we should also try to land #226 at the same time.

Copy link
Contributor

@jodh-intel jodh-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @grahamwhaley!

lgtm

@bergwolf
Copy link
Member

bergwolf commented Apr 18, 2018

LGTM, Thanks @grahamwhaley!

Approved with PullApprove

@codecov
Copy link

codecov bot commented Apr 18, 2018

Codecov Report

Merging #231 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #231   +/-   ##
=======================================
  Coverage   65.26%   65.26%           
=======================================
  Files          74       74           
  Lines        7730     7730           
=======================================
  Hits         5045     5045           
  Misses       2135     2135           
  Partials      550      550
Impacted Files Coverage Δ
virtcontainers/implementation.go 0% <ø> (ø) ⬆️
virtcontainers/noop_network.go 75% <ø> (ø) ⬆️
virtcontainers/shim.go 84.05% <ø> (ø) ⬆️
virtcontainers/kata_agent.go 33.19% <ø> (ø) ⬆️
virtcontainers/hyperstart_agent.go 57.89% <ø> (ø) ⬆️
virtcontainers/pkg/vcmock/container.go 0% <ø> (ø) ⬆️
virtcontainers/cnm.go 61.9% <ø> (ø) ⬆️
virtcontainers/proxy.go 97.18% <ø> (ø) ⬆️
virtcontainers/kata_shim.go 70% <ø> (ø) ⬆️
virtcontainers/filesystem.go 68.39% <ø> (ø) ⬆️
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdadb04...d6c3ec8. Read the comment docs.

@jodh-intel jodh-intel merged commit a85656b into kata-containers:master Apr 18, 2018
@jodh-intel jodh-intel removed the review label Apr 18, 2018
zklei pushed a commit to zklei/runtime that referenced this pull request Jun 13, 2019
yamux client runs in the proxy side, sometimes the client is handling
other requests and it's not able to response to the ping sent by the
server and the communication is closed. To avoid IO timeouts in the
communication between agent and proxy, keep alive should be disabled.

Depends-on: github.com/kata-containers/proxy#91

fixes kata-containers/proxy#70
fixes kata-containers#231

Signed-off-by: Julio Montes <julio.montes@intel.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants