Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

Update check_vendor() in .ci/static-checks.sh to deal with go.mod files. #1879

Closed
amshinde opened this issue Jul 31, 2019 · 0 comments · Fixed by #1880
Closed

Update check_vendor() in .ci/static-checks.sh to deal with go.mod files. #1879

amshinde opened this issue Jul 31, 2019 · 0 comments · Fixed by #1880
Labels
enhancement Improvement to an existing feature needs-review Needs to be assessed by the team.

Comments

@amshinde
Copy link
Member

amshinde commented Jul 31, 2019 •
edited
Loading

Reference: kata-containers/kata-containers#42

Run go mod verify instead for go modules. Note, this just verifies the integrity of modules in the local
cache. We would have instead wanted to verify the vendored code (since CI will still use the vendored packages atleast in the beginning ), but that is still not supported.
golang/go#27348
@amshinde amshinde added enhancement Improvement to an existing feature needs-review Needs to be assessed by the team. labels Jul 31, 2019
amshinde added a commit that referenced this issue Jul 31, 2019
@amshinde
modules: Verification for go modules
1e1ffaa 
While we move to go modules, perform the dep check for repos
that still use dep.
Run `go mod verify` instead for go modules.
Note, this just verifies the integrity of modules in the local
cache. We would have instead wanted to verify the vendored code
here, but that is still not supported.
golang/go#27348

Fixes #1879

Signed-off-by: Archana Shinde <archana.m.shinde@intel.com>
@amshinde amshinde mentioned this issue Jul 31, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Improvement to an existing feature needs-review Needs to be assessed by the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

modules: Verification for go modules kata-containers/tests
1 participant
@amshinde