Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

docker: fix cpu tests #706

Closed
wants to merge 1 commit into from
Closed

Conversation

bergwolf
Copy link
Member

@bergwolf bergwolf commented Sep 5, 2018

We should take the initial cpu count when setting cpu constraints.
IOW, if there is already enough cpu in the vm for a container, we
should not hotplug more CPUs.

Depends-on: kata-containers/runtime#696
Fixes: #705

@egernst egernst added the review label Sep 5, 2018
@bergwolf bergwolf requested a review from devimc September 5, 2018 03:59
@jodh-intel
Copy link
Contributor

jodh-intel commented Sep 5, 2018

lgtm

But looking at the CI logs suggests the depends-on is broken:

This PR depends on repository: kata-containers/runtime and pull request: 696
package kata-containers/runtime: unrecognized import path "kata-containers/runtime" (import path does not begin with hostname)

Approved with PullApprove

We should take the initial cpu count when setting cpu constraints.
IOW, if there is already enough cpu in the vm for a container, we
should not hotplug more CPUs.

Depends-on: github.com/kata-containers/runtime#696
Fixes: kata-containers#705

Signed-off-by: Peng Tao <bergwolf@gmail.com>
@chavafg
Copy link
Contributor

chavafg commented Sep 5, 2018

@bergwolf can you rebase your PR with latest changes? There is a fix that solves the Depends-on issue.

@jcvenegas
Copy link
Member

@devimc ping

@jcvenegas
Copy link
Member


Summarizing 15 Failures:

[Fail] Update number of CPUs Update CPU period and quota [It] should have 2 CPUs 
/tmp/jenkins/workspace/kata-containers-tests-fedora-27-PR/go/src/github.com/kata-containers/tests/integration/docker/cpu_test.go:287

[Fail] Update number of CPUs Update CPU period and quota [It] should have 3 CPUs 
/tmp/jenkins/workspace/kata-containers-tests-fedora-27-PR/go/src/github.com/kata-containers/tests/integration/docker/cpu_test.go:287

[Fail] Update number of CPUs Update CPU period and quota [It] should have 1 CPUs 
/tmp/jenkins/workspace/kata-containers-tests-fedora-27-PR/go/src/github.com/kata-containers/tests/integration/docker/cpu_test.go:287

[Fail] Update number of CPUs Update CPU constraint [It] should have 1 CPUs 
/tmp/jenkins/workspace/kata-containers-tests-fedora-27-PR/go/src/github.com/kata-containers/tests/integration/docker/cpu_test.go:309

[Fail] Update number of CPUs Update CPU constraint [It] should have 2 CPUs 
/tmp/jenkins/workspace/kata-containers-tests-fedora-27-PR/go/src/github.com/kata-containers/tests/integration/docker/cpu_test.go:309

[Fail] Update number of CPUs Update CPU constraint [It] should have 2 CPUs 
/tmp/jenkins/workspace/kata-containers-tests-fedora-27-PR/go/src/github.com/kata-containers/tests/integration/docker/cpu_test.go:309

[Fail] Update number of CPUs Update CPU constraint [It] should have 3 CPUs 
/tmp/jenkins/workspace/kata-containers-tests-fedora-27-PR/go/src/github.com/kata-containers/tests/integration/docker/cpu_test.go:309

[Fail] Update number of CPUs Update CPU constraint [It] should have 3 CPUs 
/tmp/jenkins/workspace/kata-containers-tests-fedora-27-PR/go/src/github.com/kata-containers/tests/integration/docker/cpu_test.go:309

[Fail] Hot plug CPUs container with CPU period and quota [It] should have 2 CPUs 
/tmp/jenkins/workspace/kata-containers-tests-fedora-27-PR/go/src/github.com/kata-containers/tests/integration/docker/cpu_test.go:96

[Fail] Hot plug CPUs container with CPU period and quota [It] should have 3 CPUs 
/tmp/jenkins/workspace/kata-containers-tests-fedora-27-PR/go/src/github.com/kata-containers/tests/integration/docker/cpu_test.go:96

[Fail] Hot plug CPUs container with CPU period and quota [It] should have 1 CPUs 
/tmp/jenkins/workspace/kata-containers-tests-fedora-27-PR/go/src/github.com/kata-containers/tests/integration/docker/cpu_test.go:96

[Fail] Hot plug CPUs container with CPU constraint [It] should have 1 CPUs 
/tmp/jenkins/workspace/kata-containers-tests-fedora-27-PR/go/src/github.com/kata-containers/tests/integration/docker/cpu_test.go:115

[Fail] Hot plug CPUs container with CPU constraint [It] should have 2 CPUs 
/tmp/jenkins/workspace/kata-containers-tests-fedora-27-PR/go/src/github.com/kata-containers/tests/integration/docker/cpu_test.go:115

[Fail] Hot plug CPUs container with CPU constraint [It] should have 2 CPUs 
/tmp/jenkins/workspace/kata-containers-tests-fedora-27-PR/go/src/github.com/kata-containers/tests/integration/docker/cpu_test.go:115

[Fail] Hot plug CPUs container with CPU constraint [It] should have 3 CPUs 
/tmp/jenkins/workspace/kata-containers-tests-fedora-27-PR/go/src/github.com/kata-containers/tests/integration/docker/cpu_test.go:115

Ran 200 of 211 Specs in 992.647 seconds
FAIL! -- 185 Passed | 15 Failed | 0 Pending | 11 Skipped --- FAIL: TestIntegration (1018.22s)

@bergwolf
Copy link
Member Author

bergwolf commented Sep 7, 2018

I'll drop this one for now since @devimc has a valid use case and we might introduce a new option to control the behavior.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants