This repository has been archived by the owner on Jun 28, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should take the initial cpu count when setting cpu constraints. IOW, if there is already enough cpu in the vm for a container, we should not hotplug more CPUs. Depends-on: github.com/kata-containers/runtime#696 Fixes: kata-containers#705 Signed-off-by: Peng Tao <bergwolf@gmail.com>
@bergwolf can you rebase your PR with latest changes? There is a fix that solves the Depends-on issue. |
@devimc ping |
|
I'll drop this one for now since @devimc has a valid use case and we might introduce a new option to control the behavior. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should take the initial cpu count when setting cpu constraints.
IOW, if there is already enough cpu in the vm for a container, we
should not hotplug more CPUs.
Depends-on: kata-containers/runtime#696
Fixes: #705