Radiotap extpresent #306
Closed
Radiotap extpresent #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My atheros dongle dongle actually pushes frames with extended present flags. This requires the parser to, at least, skip the extra present flags in order to continue parsing from the right place. Incidentally this arose another problem: the radiotap header specifications requires each field to be aligned to the start of the packet, and when there are two present flags bitmap, this is even less obvious. In particular the TSFT ended up to be improperly aligned here. This patch makes the radiotap parser to take care of both there issues, and fixes wrong shift/mask for extended present flag bit.
|
addressed in #517 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My atheros dongle dongle actually pushes frames with extended present flags. This requires the parser to, at least, skip the extra present flags in order to continue parsing from the right place.
Incidentally this arose another problem: the radiotap header specifications requires each field to be aligned to the start of the packet, and when there are two present flags bitmap, this is even less obvious. In particular the TSFT ended up to be improperly aligned here.
This patch makes the radiotap parser to take care of both there issues, and fixes wrong shift/mask for extended present flag bit.
Since my editor is kind enough to auto-remove trailing spaces, another trivial patch for this shows up also here..