Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve radiotap situation #478

Closed
wants to merge 3 commits into from

Conversation

remleduff
Copy link

Correct endianness issues
Support multi-byte present flags
Handle misaligned flags fields

I haven't added any new fields such as VHT, as I haven't needed them yet, but this works for me now!

See issues: #132, #306, #419

Correct endianness issues
Support multi-byte present flags
Handle misaligned flags fields
@coveralls
Copy link

coveralls commented Jul 10, 2020

Coverage Status

Coverage increased (+0.04%) to 92.507% when pulling cdf36a0 on remleduff:improve-radiotap into b5efa33 on kbandla:master.

obormot added a commit that referenced this pull request Dec 28, 2020
@obormot obormot mentioned this pull request Dec 28, 2020
@obormot
Copy link
Collaborator

obormot commented Dec 28, 2020

Superseded by #517, closing.
Thanks for the contribution @remleduff I'll work on getting your changes merged in the new PR.

@obormot obormot closed this Dec 28, 2020
obormot added a commit that referenced this pull request Dec 30, 2020
* Improve radiotap situation

Correct endianness issues
Support multi-byte present flags
Handle misaligned flags fields

* PR #478 fixes

* signed byte and padding fixes for field decoding, add unit test

Co-authored-by: Joel 'Aaron' Cohen <joel.cohen@nrl.navy.mil>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants