Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Radio buttons partly done #367

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Radio buttons partly done #367

merged 1 commit into from
Jun 12, 2024

Conversation

Kasmadei
Copy link
Collaborator

@Kasmadei Kasmadei commented Jun 5, 2024 •
edited by blcham
Loading

Fixes partially: #281

Points that needs to be added/checked.

Add:

  • Operational failure rate

Check:

  • How works tree update

@blcham I would like to discuss it tomorrow. For some reason now update endpoint was not even called :( Need some time to find out why.
Screenshot 2024-06-05 at 8 54 31 PM

blcham
blcham requested changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kasmadei I would like to have a partial solution ready by Friday lunch; please make the pull request meaningful/merge-able while delegating the problems to new issues.

src/components/editor/faultTree/menu/faultEvent/FaultEventMenu.tsx Show resolved Hide resolved
src/components/editor/faultTree/menu/faultEvent/FaultEventMenu.tsx Show resolved Hide resolved
@blcham blcham mentioned this pull request Jun 6, 2024
Open
@blcham
Copy link
Contributor

blcham commented Jun 6, 2024 •
edited
Loading

Additional info

How it should work for the selection of predicted failure rate:

  • modify event1.has-selected-failure-rate = {}
  • modify event1.probability = event1.has-selected-failure-rate.value
  • persist event1 (PUT /fault-event/event1)

maybe it is related components/editor/faultTree/menu/faultEvent/FaultEventMenu.tsx

@blcham blcham changed the title No radio buttons partly done Radio buttons partly done Jun 7, 2024
@blcham blcham mentioned this pull request Jun 7, 2024
Open
@blcham
Copy link
Contributor

blcham commented Jun 7, 2024

Relates to #377

@Kasmadei
Copy link
Collaborator Author

Kasmadei commented Jun 7, 2024

@blcham

When attempting to update a FaultEvent using the update function, a RangeError: Maximum call stack size exceeded is encountered during the axiosClient.put call. This issue appears to be related to circular references within the faultEvent object.
The application throws a RangeError: Maximum call stack size exceeded error during the axiosClient.put request:

RangeError: Maximum call stack size exceeded
    at merge (axios.js?v=802ac8ba:105:15)
    at assignValue (axios.js?v=802ac8ba:113:27)
    at forEach (axios.js?v=802ac8ba:82:10)
    at merge (axios.js?v=802ac8ba:121:21)
    at assignValue (axios.js?v=802ac8ba:113:27)
    at forEach (axios.js?v=802ac8ba:82:10)
    at merge (axios.js?v=802ac8ba:121:21)
    at assignValue (axios.js?v=802ac8ba:113:27)
    at forEach (axios.js?v=802ac8ba:82:10)
    at merge (axios.js?v=802ac8ba:121:21)

I have never see something like this. I'll try to resolve it

@Kasmadei Kasmadei force-pushed the feature/manual-and-predicted-f-rate branch from 6a2286c to c592966 Compare June 7, 2024 18:48
@blcham blcham force-pushed the feature/manual-and-predicted-f-rate branch from 524c08e to 3561122 Compare June 7, 2024 19:10
@blcham
Copy link
Contributor

blcham commented Jun 7, 2024 •
edited
Loading

Current state:

  • operational failure rate is not yet visualized correctly in FTA tree (missing "O")
  • server update is not working due to circular dependencies
    • need to check that FTA tree is refreshed after the update of fault event is done

@blcham blcham force-pushed the feature/manual-and-predicted-f-rate branch from 3561122 to fd422c7 Compare June 7, 2024 19:32
@Kasmadei Kasmadei force-pushed the feature/manual-and-predicted-f-rate branch from fd422c7 to d94ce7c Compare June 10, 2024 12:15
blcham
blcham requested changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments.

src/components/editor/faultTree/menu/faultEvent/FaultEventMenu.tsx Show resolved Hide resolved
src/components/editor/faultTree/menu/faultEvent/FaultEventMenu.tsx Show resolved Hide resolved
src/components/editor/faultTree/menu/faultEvent/FaultEventMenu.tsx Show resolved Hide resolved
src/components/editor/faultTree/menu/faultEvent/FaultEventMenu.tsx Show resolved Hide resolved
src/components/editor/faultTree/menu/faultEvent/FaultEventMenu.tsx Show resolved Hide resolved
src/components/editor/faultTree/menu/faultEvent/FaultEventMenu.tsx Show resolved Hide resolved
src/components/editor/faultTree/shapes/RenderTree.tsx Outdated Show resolved Hide resolved
@blcham
Copy link
Contributor

blcham commented Jun 10, 2024 •
edited
Loading

@LaChope please have a look at this PR

grotskat
grotskat requested changes Jun 11, 2024
View reviewed changes
public/locales/cs/translation.json Outdated Show resolved Hide resolved
public/locales/cs/translation.json Outdated Show resolved Hide resolved
public/locales/cs/translation.json Outdated Show resolved Hide resolved
public/locales/cs/translation.json Outdated Show resolved Hide resolved
@LaChope LaChope linked an issue Jun 11, 2024 that may be closed by this pull request
Implement properties of types of FTA nodes #281
Closed
@blcham blcham force-pushed the feature/manual-and-predicted-f-rate branch 2 times, most recently from 1ebe6cf to bddea57 Compare June 11, 2024 21:09
@blcham
Copy link
Contributor

blcham commented Jun 11, 2024 •
edited
Loading

@Kasmadei translations are fixed, committed and force-pushed

@Kasmadei @grotskat @blcham
[kbss-cvut#281] Support failure rate switch
2abebfd 
E.g. between operationa/predicted/manual failure rate of SNS nodes

Fixes.

Apply suggestions from code review

Co-authored-by: grotskat <93380770+grotskat@users.noreply.github.com>
@blcham blcham force-pushed the feature/manual-and-predicted-f-rate branch from bddea57 to 2abebfd Compare June 12, 2024 10:19
@blcham blcham merged commit ad59b64 into kbss-cvut:main Jun 12, 2024
1 check passed
@blcham blcham mentioned this pull request Jun 12, 2024
Open
@blcham
Copy link
Contributor

blcham commented Jun 12, 2024

@Kasmadei please process the comments

@Kasmadei Kasmadei mentioned this pull request Jun 12, 2024
Merged
This was referenced Jun 13, 2024
Closed
Closed
@LaChope LaChope mentioned this pull request Jun 17, 2024
Closed
3 tasks
blcham added a commit that referenced this pull request Jun 17, 2024
@blcham
Merge pull request #411 from akaene/fix/367-fixes-after-comments
7148829 
[#367] Fixes after PR review.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grotskat grotskat grotskat requested changes

@LaChope LaChope LaChope left review comments

@blcham blcham blcham requested changes

Assignees

@Kasmadei Kasmadei

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement properties of types of FTA nodes
4 participants
@Kasmadei @blcham @LaChope @grotskat