Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme.md #25

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Update readme.md #25

merged 1 commit into from
Feb 14, 2023

Conversation

hardys
Copy link

@hardys hardys commented Feb 9, 2023

This adds some more usage information based on additions from #23 which was recently closed

Co-Authored-By: Mangirdas Judeikis mangirdas@judeikis.lt

This adds some more usage information based on additions from kcp-dev#23

Co-Authored-By: Mangirdas Judeikis <mangirdas@judeikis.lt>
@hardys
Copy link
Author

hardys commented Feb 9, 2023

/cc @mjudeikis @s-urbaniak

I noticed #23 had some useful additions to the readme and a values example, so I made some similar changes here

@hardys
Copy link
Author

hardys commented Feb 9, 2023

/assign @s-urbaniak

@mjudeikis
Copy link
Contributor

I will check it out during weekend. Had way more in my other fork too :) thanks!

@cychiang
Copy link

Hi! I'm trying to deploy kcp to a kind cluster but it seems missing some important parts, like:

  • s.Options.Extra.ShardVirtualWorkspaceCAFile, not sure where to import this file.
  • "command failed" err="--shards-kubeconfig is required" when starting a kcp-front-proxy

Not sure how to solve it and continue to make it works. Could you point me some ways to work on? Thanks!

@mjudeikis
Copy link
Contributor

@hardys this looks good enough.
Its not part of this PR, but I would change these things if possible (sorry, late to the review train on previous PR):

- --shard-virtual-workspace-ca-file=/etc/kcp/tls/server-client/ca.crt is missing in KCP pod spec

and I would change this as this allow rapid dev deployment into KIND without need to have proper DNS configured (will add how to get it running in follow-up PR)
image

OR we can just merge this and I will do follow-up PR with my proposed changes :) Your call

/lgtm

@hardys
Copy link
Author

hardys commented Feb 14, 2023

  • --shard-virtual-workspace-ca-file=/etc/kcp/tls/server-client/ca.crt is missing in KCP pod spec

That should not be required since kcp-dev/kcp#2659 (for now I removed the standalone VW option from the templates, until we resolve issues discussed via kcp-dev/kcp#2672) - can you confirm which KCP image you're using?

@hardys
Copy link
Author

hardys commented Feb 14, 2023

Hi! I'm trying to deploy kcp to a kind cluster but it seems missing some important parts, like:

* `s.Options.Extra.ShardVirtualWorkspaceCAFile`, not sure where to import this file.

* `"command failed" err="--shards-kubeconfig is required"` when starting a `kcp-front-proxy`

Not sure how to solve it and continue to make it works. Could you point me some ways to work on? Thanks!

@cychiang please check you have the latest version of the chart - the shards-kubeconfig issue was resolved in #24 - if you still have issues after pulling the latest, please open an issue with more details, thanks!

@hardys
Copy link
Author

hardys commented Feb 14, 2023

@ncdc or @s-urbaniak perhaps you could merge this and we'll deal with any further additions as follow-ups?

@ncdc
Copy link
Member

ncdc commented Feb 14, 2023

@hardys you have merge permissions now

@ncdc ncdc merged commit 5ce0cad into kcp-dev:main Feb 14, 2023
@hardys
Copy link
Author

hardys commented Feb 14, 2023

Hi! I'm trying to deploy kcp to a kind cluster but it seems missing some important parts, like:

* `s.Options.Extra.ShardVirtualWorkspaceCAFile`, not sure where to import this file.

* `"command failed" err="--shards-kubeconfig is required"` when starting a `kcp-front-proxy`

Not sure how to solve it and continue to make it works. Could you point me some ways to work on? Thanks!

@cychiang please check you have the latest version of the chart - the shards-kubeconfig issue was resolved in #24 - if you still have issues after pulling the latest, please open an issue with more details, thanks!

I see now we forgot to tag a new release https://github.com/kcp-dev/helm-charts/releases/tag/kcp-0.2.5 now tagged

@cychiang
Copy link

@hardys Thanks, I will give it a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants