Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] 🐛 sharded-test-server: Add external-hostname flag #2672

Closed
wants to merge 1 commit into from

Conversation

hardys
Copy link

@hardys hardys commented Jan 25, 2023

Summary

We are seeing real cluster deployments of KCP fail because the external-hostname and shard-external-url flags typically point to the front-proxy endpoint, this aligns the e2e behavior so we can work through the issues with chicken/egg availability during shard bootstrapping and discuss the best solution.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 25, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 25, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ncdc for approval by writing /assign @ncdc in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hardys
Copy link
Author

hardys commented Jan 25, 2023

@ncdc I think this reproduces the issues seen in "real" cluster deployments, because we're using the ExternalAddress for the vwURL since #2407 - I tried to work around that in #2667

How is controller sharding handled? I assume we can't just use ShardBaseURL for the controller traffic because it may potentially need to be routed to another shard via the proxy indexer?

We are seeing real cluster deployments of KCP fail because the
external-hostname and shard-external-url flags typically point to
the front-proxy endpoint, this aligns the e2e behavior so we can
work through the issues with chicken/egg availability during shard
bootstrapping.
@hardys hardys force-pushed the sharded_bootstrap_fixes branch from 599df20 to 2a5795a Compare January 30, 2023 13:59
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 30, 2023

@hardys: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-sharded 2a5795a link true /test e2e-sharded

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ncdc
Copy link
Member

ncdc commented Apr 4, 2023

@hardys I think I missed your question above somehow. Wanted to follow up and see if we still want this PR? If so, how can I help?

@hardys hardys closed this May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants