Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add post-kcp-publish-image job #46

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Jun 7, 2023

This is the sister PR to kcp-dev/kcp#2976, adding the necessary postsubmit.

Images were previously built for main/release branches and for tags ( https://github.com/kcp-dev/kcp/blob/main/.github/workflows/kcp-image.yaml#L8-L12 ), so I kept this behaviour.

@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 7, 2023
@sttts
Copy link
Member

sttts commented Jun 9, 2023

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2023
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 94ca0f8233b1bbc4191d0eb69be5f58b2729bed4

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2023
@kcp-ci-bot kcp-ci-bot merged commit 482644d into kcp-dev:main Jun 9, 2023
@kcp-ci-bot
Copy link
Contributor

@xrstf: Updated the job-config configmap in namespace prow at cluster default using the following files:

  • key prow-jobs-kcp-kcp-postsubmits.yaml using file prow/jobs/kcp/kcp-postsubmits.yaml

In response to this:

This is the sister PR to kcp-dev/kcp#2976, adding the necessary postsubmit.

Images were previously built for main/release branches and for tags ( https://github.com/kcp-dev/kcp/blob/main/.github/workflows/kcp-image.yaml#L8-L12 ), so I kept this behaviour.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xrstf xrstf deleted the add-kcp-image-postsubmit branch October 23, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants