Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add images Prowjob #2976

Merged
merged 2 commits into from
Jun 11, 2023
Merged

🌱 Add images Prowjob #2976

merged 2 commits into from
Jun 11, 2023

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Jun 6, 2023

Summary

This PR is part 1 of 2 to convert the Github Workflow for building the kcp container image innto a regular Prowjob. Part 2 will happen in the infra repository, as the postsubmit will need elevated credentials and so has to be maintained there.

I've used buildah to build the image because that's what I'm used to and it seems to work just fine.

part of kcp-dev/infra#43

Release Note

NONE

@kcp-ci-bot kcp-ci-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. dco-signoff: yes Indicates the PR's author has signed the DCO. labels Jun 6, 2023
@openshift-ci openshift-ci bot requested review from clubanderson and csams June 6, 2023 20:37
@kcp-ci-bot kcp-ci-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 6, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xrstf
Copy link
Contributor Author

xrstf commented Jun 6, 2023

/test pull-kcp-build-image

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 6, 2023

@xrstf: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test boilerplate
  • /test codegen
  • /test deps
  • /test e2e
  • /test e2e-multiple-runs
  • /test e2e-sharded
  • /test e2e-shared
  • /test images
  • /test imports
  • /test lint
  • /test modules
  • /test test

Use /test all to run all jobs.

In response to this:

/test pull-kcp-build-image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xrstf xrstf force-pushed the add-images-prowjob branch from 82ce28c to 8a5285f Compare June 6, 2023 21:09
@xrstf
Copy link
Contributor Author

xrstf commented Jun 6, 2023

/test pull-kcp-build-image

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 6, 2023

@xrstf: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test boilerplate
  • /test codegen
  • /test deps
  • /test e2e
  • /test e2e-multiple-runs
  • /test e2e-sharded
  • /test e2e-shared
  • /test images
  • /test imports
  • /test lint
  • /test modules
  • /test test

Use /test all to run all jobs.

In response to this:

/test pull-kcp-build-image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xrstf xrstf force-pushed the add-images-prowjob branch from 8a5285f to d81f801 Compare June 6, 2023 22:17
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 6, 2023

@xrstf: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/deps d81f801 link true /test deps
ci/prow/lint d81f801 link true /test lint
ci/prow/codegen d81f801 link true /test codegen
ci/prow/e2e-sharded d81f801 link true /test e2e-sharded
ci/prow/modules d81f801 link true /test modules
ci/prow/e2e-shared d81f801 link true /test e2e-shared
ci/prow/images d81f801 link true /test images
ci/prow/e2e d81f801 link true /test e2e
ci/prow/imports d81f801 link true /test imports
ci/prow/e2e-multiple-runs d81f801 link true /test e2e-multiple-runs
ci/prow/boilerplate d81f801 link true /test boilerplate
ci/prow/test d81f801 link true /test test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@xrstf xrstf force-pushed the add-images-prowjob branch from 0431d17 to ae506f5 Compare June 7, 2023 10:27
@xrstf xrstf force-pushed the add-images-prowjob branch from ae506f5 to f90b590 Compare June 7, 2023 10:38
@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 7, 2023
@xrstf xrstf changed the title 🌱 - WIP Add images prowjob 🌱 Add images prowjob Jun 7, 2023
@xrstf xrstf changed the title 🌱 Add images prowjob 🌱 Add images Prowjob Jun 7, 2023
@xrstf
Copy link
Contributor Author

xrstf commented Jun 7, 2023

/retest

@palnabarun
Copy link
Member

/test pull-kcp-test-e2e

@sttts
Copy link
Member

sttts commented Jun 9, 2023

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2023
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b7f3d950ab1fb4a8d101e92eecac7e2d2fcec909

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2023
@mjudeikis
Copy link
Contributor

/retest

1 similar comment
@xrstf
Copy link
Contributor Author

xrstf commented Jun 11, 2023

/retest

@kcp-ci-bot kcp-ci-bot merged commit 1c308b5 into kcp-dev:main Jun 11, 2023
@xrstf xrstf deleted the add-images-prowjob branch June 11, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants