Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Move builds for ghcr.io/kcp-dev/infra/build to prow #50

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

embik
Copy link
Member

@embik embik commented Jun 13, 2023

Initially I added builds for ghcr.io/kcp-dev/infra/build in #35 via GitHub Actions because that was how kcp-dev/kcp was doing it. Now the core repository has migrated to building images in prow, so this PR adapts the changes made there (kcp-dev/kcp#2976) into the infra repository for our build image as well.

I'm leaving the multi-arch aspect in because I find it useful, it's less divergence from the kcp script and it could unlock running jobs on ARM if we later chose so, by just dropping that architecture in the list for our build image.

@kcp-ci-bot kcp-ci-bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Jun 13, 2023
@embik embik changed the title 🌱 Move builds for ghcr.io/kcp-dev/infra/build to prow WIP: 🌱 Move builds for ghcr.io/kcp-dev/infra/build to prow Jun 13, 2023
@kcp-ci-bot kcp-ci-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 13, 2023
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@embik embik force-pushed the kcp-build-image-on-prow branch from 8ea87c3 to f380cf0 Compare June 13, 2023 10:13
@embik
Copy link
Member Author

embik commented Jun 13, 2023

/cc @xrstf

@kcp-ci-bot kcp-ci-bot requested a review from xrstf June 13, 2023 10:13
@embik embik changed the title WIP: 🌱 Move builds for ghcr.io/kcp-dev/infra/build to prow 🌱 Move builds for ghcr.io/kcp-dev/infra/build to prow Jun 13, 2023
@kcp-ci-bot kcp-ci-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 13, 2023
@embik embik changed the title 🌱 Move builds for ghcr.io/kcp-dev/infra/build to prow 🌱 Move builds for ghcr.io/kcp-dev/infra/build to prow Jun 13, 2023
@xrstf
Copy link
Contributor

xrstf commented Jun 13, 2023

/approve
/lgtm

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2023
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e1c808454abe6ccf71109b838354f26fe9abb796

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2023
@kcp-ci-bot kcp-ci-bot merged commit 27bd350 into kcp-dev:main Jun 13, 2023
@kcp-ci-bot
Copy link
Contributor

@embik: Updated the job-config configmap in namespace prow at cluster default using the following files:

  • key prow-jobs-infra-infra-postsubmits.yaml using file prow/jobs/infra/infra-postsubmits.yaml
  • key prow-jobs-infra-infra-presubmits.yaml using file prow/jobs/infra/infra-presubmits.yaml

In response to this:

Initially I added builds for ghcr.io/kcp-dev/infra/build in #35 via GitHub Actions because that was how kcp-dev/kcp was doing it. Now the core repository has migrated to building images in prow, so this PR adapts the changes made there (kcp-dev/kcp#2976) into the infra repository for our build image as well.

I'm leaving the multi-arch aspect in because I find it useful, it's less divergence from the kcp script and it could unlock running jobs on ARM if we later chose so, by just dropping that architecture in the list for our build image.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@embik embik deleted the kcp-build-image-on-prow branch June 13, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants