-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Move builds for ghcr.io/kcp-dev/infra/build
to prow
#50
Conversation
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
8ea87c3
to
f380cf0
Compare
/cc @xrstf |
ghcr.io/kcp-dev/infra/build
to prow
/approve |
LGTM label has been added. Git tree hash: e1c808454abe6ccf71109b838354f26fe9abb796
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@embik: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Initially I added builds for
ghcr.io/kcp-dev/infra/build
in #35 via GitHub Actions because that was how kcp-dev/kcp was doing it. Now the core repository has migrated to building images in prow, so this PR adapts the changes made there (kcp-dev/kcp#2976) into the infra repository for our build image as well.I'm leaving the multi-arch aspect in because I find it useful, it's less divergence from the kcp script and it could unlock running jobs on ARM if we later chose so, by just dropping that architecture in the list for our build image.