✨ *: use cluster-aware keyfuncs & splitters #1958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
kind/api-change
stevekuznetsov
force-pushed
the
skuznets/use-cluster-aware-keyfunc
branch
from
31ee1b5 to
5f672d1
Compare
stevekuznetsov
commented
Sep 12, 2022
| if err != nil { | ||
| runtime.HandleError(err) | ||
| return nil | ||
| } | ||
| // e.g. root:org<separator>ws |
There was a problem hiding this comment.
Hm, crap - Need to do a lot more work to get comments munged correctly ... would likely need to merge this with any from the first statement, since this SplitClusterAwareKey node gets removed entirely
stevekuznetsov
commented
Sep 12, 2022
|
I think there are legit failures from the changes here? |
|
That's ... concerning. I'll check tomorrow - syncer unit tests likely are from the test fakes? |
This was referenced Sep 14, 2022
stevekuznetsov
force-pushed
the
skuznets/use-cluster-aware-keyfunc
branch
2 times, most recently
from
159d0a2 to
c579202
Compare
openshift-merge-robot
added
the
needs-rebase
stevekuznetsov
force-pushed
the
skuznets/use-cluster-aware-keyfunc
branch
from
c579202 to
230a885
Compare
openshift-merge-robot
removed
the
needs-rebase
stevekuznetsov
force-pushed
the
skuznets/use-cluster-aware-keyfunc
branch
2 times, most recently
from
8a8f90b to
d303897
Compare
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
These tests are ripe for being updated to assume less about the system. Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
stevekuznetsov
force-pushed
the
skuznets/use-cluster-aware-keyfunc
branch
from
ba95b60 to
25fdd02
Compare
|
OK, rebased on all re-reqs. Passing locally. @ncdc ready for review |
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
sttts
reviewed
Sep 15, 2022
pkg/reconciler/apis/apibindingdeletion/apibinding_deletion_controller.go
Show resolved
Hide resolved
sttts
reviewed
Sep 15, 2022
ncdc
reviewed
Sep 15, 2022
ncdc
reviewed
Sep 15, 2022
ncdc
reviewed
Sep 15, 2022
ncdc
approved these changes
Sep 15, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go.mod: use newest kcp-dev/apimachinery
Signed-off-by: Steve Kuznetsov skuznets@redhat.com
*: use cluster-aware keyfuncs & splitters
Signed-off-by: Steve Kuznetsov skuznets@redhat.com
Part of #209
Generated with kcp-dev/code-generator#53
/assign @ncdc @sttts