🐛 syncer: use the correct key splitter #1985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevekuznetsov
force-pushed
the
skuznets/use-cluster-unaware-keyfunc
branch
2 times, most recently
from
0a6675d to
b85c322
Compare
ncdc
approved these changes
Sep 14, 2022
openshift-ci
bot
added
lgtm
The status controller uses a cluster-unaware keyfunction, so it is not meaningful to use a cluster-aware splitter. Furthermore, there is no case in which the downstream informer will have cluster-aware keys. Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
stevekuznetsov
force-pushed
the
skuznets/use-cluster-unaware-keyfunc
branch
from
b85c322 to
6996de5
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/retest |
|
/refresh |
|
omg pls merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The status controller uses a cluster-unaware keyfunction, so it is not meaningful to use a cluster-aware splitter. Furthermore, there is no case in which the downstream informer will have cluster-aware keys.
Signed-off-by: Steve Kuznetsov skuznets@redhat.com
Needed for #1958
/assign @jmprusi
/cc @ncdc