✨ enable shard scheduling and fix e2e tests #2596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
sttts
force-pushed
the
sttts-random-workspace-scheduling
branch
from
025560e to
ed08ff7
Compare
openshift-ci
bot
added
the
kind/api-change
sttts
force-pushed
the
sttts-random-workspace-scheduling
branch
from
ed08ff7 to
df7ce89
Compare
openshift-merge-robot
added
the
needs-rebase
sttts
force-pushed
the
sttts-random-workspace-scheduling
branch
3 times, most recently
from
de413ee to
2b4cc23
Compare
sttts
force-pushed
the
sttts-random-workspace-scheduling
branch
2 times, most recently
from
15cd60f to
832a4a5
Compare
openshift-merge-robot
removed
the
needs-rebase
p0lyn0mial
force-pushed
the
sttts-random-workspace-scheduling
branch
from
018c30b to
e5ea069
Compare
|
/retest |
This was referenced Jan 17, 2023
openshift-merge-robot
added
the
needs-rebase
This was referenced Jan 19, 2023
p0lyn0mial
force-pushed
the
sttts-random-workspace-scheduling
branch
from
e5ea069 to
7a39f13
Compare
openshift-merge-robot
removed
the
needs-rebase
sttts
force-pushed
the
sttts-random-workspace-scheduling
branch
from
7a39f13 to
5826776
Compare
…irtualWorkspaceAccess to multi shard
sttts
force-pushed
the
sttts-random-workspace-scheduling
branch
from
6c5038c to
8f04da8
Compare
|
/retest |
|
can we merge this PR? |
|
/retest all |
|
@p0lyn0mial: The
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test all |
sttts
changed the title
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching on random scheduling of workspaces to shards.
The current state of e2e tests:
✅ apibinding
✅ audit
✅ authorizer
✅ cache
✅ test/e2e/conformance (@fgiloux sttts#14 - the fix pulled into this PR)
✅ customresourcedefinition
✅ garbagecollector (@p0lyn0mial: Originally reported as
redbut after running it a few times on my local machine and examining a CI run I moved togreen)✅ homeworkspaces
✅ test/e2e/watchcache (flakes, @p0lyn0mial, fixed by: #2632)
✅ workspacetype
✅ reconciler/apiexport
✅ reconciler/cache (@p0lyn0mial, fixed by: #2620)
✅ test/e2e/reconciler/workspace (@p0lyn0mial, fixed by: #2639)
✅ quota
✅ reconcilder/*
✅ virtual/*
🔴 quota (@ncdc)🔴 apibinding🔴 authorizer, flakes (@sur)⚫ skipped: test/e2e/reconciler/locationworkspace (@p0lyn0mial, temporal fix in #2650)
⚫ skipped: test/e2e/reconciler/scheduling (@p0lyn0mial, temporal fix in #2651)
⚫ skipped: test/e2e/reconciler/cluster (@p0lyn0mial, temporal fix in #2657)
⚫ skipped: test/e2e/recocniler/namespace (@p0lyn0mial, temporal fix in #2658)
⚫ skipped: test/e2e/syncer (@p0lyn0mial, temporal fix in #2652)
🔴 test/e2e/virtual/apiexport (@p0lyn0mial/@sur, opened #2641 but I think that more fixes are required)🔴 test/e2e/virtual/initializingworkspaces (@p0lyn0mial, opened #2660 but we need more fixes)some useful commands:
to run
apibindinge2e tests against a multi-shard environment:to run all e2e tests on a multi-shard environment:
to find out what is replicated into the cache and when: